Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-7266] Add ExpectsInputTypes to expressions when possible. #5796

Closed
wants to merge 1 commit into from
Closed

[SPARK-7266] Add ExpectsInputTypes to expressions when possible. #5796

wants to merge 1 commit into from

Conversation

rxin
Copy link
Contributor

@rxin rxin commented Apr 30, 2015

This should gives us better analysis time error messages (rather than runtime) and automatic type casting.

@rxin
[SPARK-7266] Add ExpectsInputTypes to expressions when possible.
c900760 
This should gives us better analysis time error messages (rather than runtime) and automatic type casting.
@SparkQA
Copy link

SparkQA commented Apr 30, 2015

Test build #31362 has finished for PR 5796 at commit c900760.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • case class Not(child: Expression) extends UnaryExpression with Predicate with ExpectsInputTypes
    • case class And(left: Expression, right: Expression)
    • case class Or(left: Expression, right: Expression)
    • abstract class BinaryComparison extends BinaryExpression with Predicate
    • trait StringRegexExpression extends ExpectsInputTypes
    • trait CaseConversionExpression extends ExpectsInputTypes
    • case class Substring(str: Expression, pos: Expression, len: Expression)
  • This patch does not change any dependencies.

@rxin
Copy link
Contributor Author

rxin commented May 4, 2015

cc @yhuai can you review this?

@yhuai
Copy link
Contributor

yhuai commented May 5, 2015

LGTM

@rxin
Copy link
Contributor Author

rxin commented May 5, 2015

Thanks. Merging in master and branch-1.4.

asfgit pushed a commit that referenced this pull request May 5, 2015
@rxin
[SPARK-7266] Add ExpectsInputTypes to expressions when possible.
1388a46 
This should gives us better analysis time error messages (rather than runtime) and automatic type casting.

Author: Reynold Xin <rxin@databricks.com>

Closes #5796 from rxin/expected-input-types and squashes the following commits:

c900760 [Reynold Xin] [SPARK-7266] Add ExpectsInputTypes to expressions when possible.

(cherry picked from commit 678c4da)
Signed-off-by: Reynold Xin <rxin@databricks.com>
@asfgit asfgit closed this in 678c4da May 5, 2015
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request May 28, 2015
@rxin @jeanlyn
[SPARK-7266] Add ExpectsInputTypes to expressions when possible.
19bef12 
This should gives us better analysis time error messages (rather than runtime) and automatic type casting.

Author: Reynold Xin <rxin@databricks.com>

Closes apache#5796 from rxin/expected-input-types and squashes the following commits:

c900760 [Reynold Xin] [SPARK-7266] Add ExpectsInputTypes to expressions when possible.
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request Jun 12, 2015
@rxin @jeanlyn
[SPARK-7266] Add ExpectsInputTypes to expressions when possible.
3b64cda 
This should gives us better analysis time error messages (rather than runtime) and automatic type casting.

Author: Reynold Xin <rxin@databricks.com>

Closes apache#5796 from rxin/expected-input-types and squashes the following commits:

c900760 [Reynold Xin] [SPARK-7266] Add ExpectsInputTypes to expressions when possible.
nemccarthy pushed a commit to nemccarthy/spark that referenced this pull request Jun 19, 2015
@rxin @nemccarthy
[SPARK-7266] Add ExpectsInputTypes to expressions when possible.
665fa2c 
This should gives us better analysis time error messages (rather than runtime) and automatic type casting.

Author: Reynold Xin <rxin@databricks.com>

Closes apache#5796 from rxin/expected-input-types and squashes the following commits:

c900760 [Reynold Xin] [SPARK-7266] Add ExpectsInputTypes to expressions when possible.
@marmbrus marmbrus mentioned this pull request Jul 9, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@rxin @SparkQA @yhuai