-
Notifications
You must be signed in to change notification settings - Fork 28.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-7081] Faster sort-based shuffle path using binary processing cache-aware sort #5868
Commits on May 1, 2015
-
Configuration menu - View commit details
-
Copy full SHA for 81d52c5 - Browse repository at this point
Copy the full SHA 81d52c5View commit details -
Configuration menu - View commit details
-
Copy full SHA for abf7bfe - Browse repository at this point
Copy the full SHA abf7bfeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 57a4ea0 - Browse repository at this point
Copy the full SHA 57a4ea0View commit details -
Configuration menu - View commit details
-
Copy full SHA for e900152 - Browse repository at this point
Copy the full SHA e900152View commit details -
Fix invalid range in UnsafeSorter.
TODO: write fuzz tests to uncover stuff like this. Sorting has nice invariants; should be an easy test to write.
Configuration menu - View commit details
-
Copy full SHA for 767d3ca - Browse repository at this point
Copy the full SHA 767d3caView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3db12de - Browse repository at this point
Copy the full SHA 3db12deView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4d2f5e1 - Browse repository at this point
Copy the full SHA 4d2f5e1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8e3ec20 - Browse repository at this point
Copy the full SHA 8e3ec20View commit details -
Configuration menu - View commit details
-
Copy full SHA for 253f13e - Browse repository at this point
Copy the full SHA 253f13eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9c6cf58 - Browse repository at this point
Copy the full SHA 9c6cf58View commit details -
Configuration menu - View commit details
-
Copy full SHA for e267cee - Browse repository at this point
Copy the full SHA e267ceeView commit details -
Expand serializer API and use new function to help control when new U…
…nsafeShuffle path is used.
Configuration menu - View commit details
-
Copy full SHA for e2d96ca - Browse repository at this point
Copy the full SHA e2d96caView commit details -
Configuration menu - View commit details
-
Copy full SHA for d3cc310 - Browse repository at this point
Copy the full SHA d3cc310View commit details -
Configuration menu - View commit details
-
Copy full SHA for 87e721b - Browse repository at this point
Copy the full SHA 87e721bView commit details
Commits on May 2, 2015
-
Configuration menu - View commit details
-
Copy full SHA for 0748458 - Browse repository at this point
Copy the full SHA 0748458View commit details -
Configuration menu - View commit details
-
Copy full SHA for 026b497 - Browse repository at this point
Copy the full SHA 026b497View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1433b42 - Browse repository at this point
Copy the full SHA 1433b42View commit details -
Configuration menu - View commit details
-
Copy full SHA for 240864c - Browse repository at this point
Copy the full SHA 240864cView commit details
Commits on May 3, 2015
-
Add tests for serializer relocation property.
I verified that the Kryo tests will fail if we remove the auto-reset check in KryoSerializer. I also checked that this test fails if we mistakenly enable this flag for JavaSerializer. This demonstrates that the test case is actually capable of detecting the types of bugs that it's trying to prevent. Of course, it's possible that certain bugs will only surface when serializing specific data types, so we'll still have to be cautious when overriding `supportsRelocationOfSerializedObjects` for new serializers.
Configuration menu - View commit details
-
Copy full SHA for bfc12d3 - Browse repository at this point
Copy the full SHA bfc12d3View commit details -
Configuration menu - View commit details
-
Copy full SHA for b8a09fe - Browse repository at this point
Copy the full SHA b8a09feView commit details -
Small refactoring of SerializerPropertiesSuite to enable test re-use:
This lays some groundwork for re-using this test logic for serializers defined in other subprojects (those projects can just declare a test-jar dependency on Spark core).
Configuration menu - View commit details
-
Copy full SHA for c2fca17 - Browse repository at this point
Copy the full SHA c2fca17View commit details -
Configuration menu - View commit details
-
Copy full SHA for f17fa8f - Browse repository at this point
Copy the full SHA f17fa8fView commit details -
Fix bug in calculating free space in current page.
This broke off-heap mode.
Configuration menu - View commit details
-
Copy full SHA for 8958584 - Browse repository at this point
Copy the full SHA 8958584View commit details -
Configuration menu - View commit details
-
Copy full SHA for 595923a - Browse repository at this point
Copy the full SHA 595923aView commit details
Commits on May 4, 2015
-
Configuration menu - View commit details
-
Copy full SHA for 5e100b2 - Browse repository at this point
Copy the full SHA 5e100b2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2776aca - Browse repository at this point
Copy the full SHA 2776acaView commit details -
Configuration menu - View commit details
-
Copy full SHA for f156a8f - Browse repository at this point
Copy the full SHA f156a8fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3490512 - Browse repository at this point
Copy the full SHA 3490512View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3aeaff7 - Browse repository at this point
Copy the full SHA 3aeaff7View commit details
Commits on May 5, 2015
-
Configuration menu - View commit details
-
Copy full SHA for 7ee918e - Browse repository at this point
Copy the full SHA 7ee918eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 69232fd - Browse repository at this point
Copy the full SHA 69232fdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 57f1ec0 - Browse repository at this point
Copy the full SHA 57f1ec0View commit details -
Configuration menu - View commit details
-
Copy full SHA for f480fb2 - Browse repository at this point
Copy the full SHA f480fb2View commit details -
WIP towards testing UnsafeShuffleWriter.
Unfortunately, this involved a TON of mocks; maybe it would be easier to split the writer into more objects, such as a spiller and merger, as I did when the sorting code was more generic.
Configuration menu - View commit details
-
Copy full SHA for 133c8c9 - Browse repository at this point
Copy the full SHA 133c8c9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4f70141 - Browse repository at this point
Copy the full SHA 4f70141View commit details
Commits on May 6, 2015
-
Configuration menu - View commit details
-
Copy full SHA for aaea17b - Browse repository at this point
Copy the full SHA aaea17bView commit details -
Merge remote-tracking branch 'origin/master' into unsafe-sort
Conflicts: core/src/main/scala/org/apache/spark/serializer/KryoSerializer.scala core/src/main/scala/org/apache/spark/serializer/Serializer.scala core/src/test/scala/org/apache/spark/serializer/SerializerPropertiesSuite.scala sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlSerializer2.scala
Configuration menu - View commit details
-
Copy full SHA for b674412 - Browse repository at this point
Copy the full SHA b674412View commit details
Commits on May 7, 2015
-
Configuration menu - View commit details
-
Copy full SHA for 11feeb6 - Browse repository at this point
Copy the full SHA 11feeb6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8a6fe52 - Browse repository at this point
Copy the full SHA 8a6fe52View commit details -
Configuration menu - View commit details
-
Copy full SHA for cfe0ec4 - Browse repository at this point
Copy the full SHA cfe0ec4View commit details -
Remove upper type bound in ShuffleWriter interface.
This bound wasn't necessary and was causing IntelliJ to display spurious errors when editing UnsafeShuffleWriter.java.
Configuration menu - View commit details
-
Copy full SHA for e67f1ea - Browse repository at this point
Copy the full SHA e67f1eaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5e8cf75 - Browse repository at this point
Copy the full SHA 5e8cf75View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1ce1300 - Browse repository at this point
Copy the full SHA 1ce1300View commit details -
Configuration menu - View commit details
-
Copy full SHA for b95e642 - Browse repository at this point
Copy the full SHA b95e642View commit details
Commits on May 8, 2015
-
Configuration menu - View commit details
-
Copy full SHA for 9883e30 - Browse repository at this point
Copy the full SHA 9883e30View commit details -
Configuration menu - View commit details
-
Copy full SHA for 722849b - Browse repository at this point
Copy the full SHA 722849bView commit details
Commits on May 9, 2015
-
Configuration menu - View commit details
-
Copy full SHA for 7cd013b - Browse repository at this point
Copy the full SHA 7cd013bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9b7ebed - Browse repository at this point
Copy the full SHA 9b7ebedView commit details -
Configuration menu - View commit details
-
Copy full SHA for e8718dd - Browse repository at this point
Copy the full SHA e8718ddView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1929a74 - Browse repository at this point
Copy the full SHA 1929a74View commit details
Commits on May 10, 2015
-
Configuration menu - View commit details
-
Copy full SHA for 01afc74 - Browse repository at this point
Copy the full SHA 01afc74View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8f5061a - Browse repository at this point
Copy the full SHA 8f5061aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 67d25ba - Browse repository at this point
Copy the full SHA 67d25baView commit details -
Configuration menu - View commit details
-
Copy full SHA for fd4bb9e - Browse repository at this point
Copy the full SHA fd4bb9eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9d1ee7c - Browse repository at this point
Copy the full SHA 9d1ee7cView commit details -
Configuration menu - View commit details
-
Copy full SHA for fcd9a3c - Browse repository at this point
Copy the full SHA fcd9a3cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 27b18b0 - Browse repository at this point
Copy the full SHA 27b18b0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4a01c45 - Browse repository at this point
Copy the full SHA 4a01c45View commit details
Commits on May 11, 2015
-
Configuration menu - View commit details
-
Copy full SHA for f780fb1 - Browse repository at this point
Copy the full SHA f780fb1View commit details -
Configuration menu - View commit details
-
Copy full SHA for b57c17f - Browse repository at this point
Copy the full SHA b57c17fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1ef56c7 - Browse repository at this point
Copy the full SHA 1ef56c7View commit details -
Properly implement close() and flush() in DummySerializerInstance.
It turns out that we actually rely on these flushing the underlying stream in order to properly close streams in DiskBlockObjectWriter; it was silly of me to not implement these methods. This should fix a failing LZ4 test in UnsafeShuffleWriterSuite.
Configuration menu - View commit details
-
Copy full SHA for b3b1924 - Browse repository at this point
Copy the full SHA b3b1924View commit details -
Bump up shuffle.memoryFraction to make tests pass.
We'll want to revisit this before merging, since the large minimum memory usage means that minimum memory requirements for shuffle may be fairly high for local tests.
Configuration menu - View commit details
-
Copy full SHA for 0d4d199 - Browse repository at this point
Copy the full SHA 0d4d199View commit details -
Configuration menu - View commit details
-
Copy full SHA for ec6d626 - Browse repository at this point
Copy the full SHA ec6d626View commit details -
Configuration menu - View commit details
-
Copy full SHA for ae538dc - Browse repository at this point
Copy the full SHA ae538dcView commit details -
Configuration menu - View commit details
-
Copy full SHA for ea4f85f - Browse repository at this point
Copy the full SHA ea4f85fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1e3ad52 - Browse repository at this point
Copy the full SHA 1e3ad52View commit details -
Configuration menu - View commit details
-
Copy full SHA for 39434f9 - Browse repository at this point
Copy the full SHA 39434f9View commit details -
Configuration menu - View commit details
-
Copy full SHA for e1855e5 - Browse repository at this point
Copy the full SHA e1855e5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7c953f9 - Browse repository at this point
Copy the full SHA 7c953f9View commit details -
Add tests that automatically trigger spills.
This bumps up line coverage to 93% in UnsafeShuffleExternalSorter; now, the only branches that are missed are exception-handling code.
Configuration menu - View commit details
-
Copy full SHA for 8531286 - Browse repository at this point
Copy the full SHA 8531286View commit details -
Configuration menu - View commit details
-
Copy full SHA for 69d5899 - Browse repository at this point
Copy the full SHA 69d5899View commit details -
Configuration menu - View commit details
-
Copy full SHA for d4e6d89 - Browse repository at this point
Copy the full SHA d4e6d89View commit details
Commits on May 12, 2015
-
20
Configuration menu - View commit details
-
Copy full SHA for 4f0b770 - Browse repository at this point
Copy the full SHA 4f0b770View commit details -
Configuration menu - View commit details
-
Copy full SHA for e58a6b4 - Browse repository at this point
Copy the full SHA e58a6b4View commit details -
Configuration menu - View commit details
-
Copy full SHA for e995d1a - Browse repository at this point
Copy the full SHA e995d1aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 56781a1 - Browse repository at this point
Copy the full SHA 56781a1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0ad34da - Browse repository at this point
Copy the full SHA 0ad34daView commit details -
Configuration menu - View commit details
-
Copy full SHA for 85da63f - Browse repository at this point
Copy the full SHA 85da63fView commit details -
Configuration menu - View commit details
-
Copy full SHA for fdcac08 - Browse repository at this point
Copy the full SHA fdcac08View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2d4e4f4 - Browse repository at this point
Copy the full SHA 2d4e4f4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 57312c9 - Browse repository at this point
Copy the full SHA 57312c9View commit details -
Remove ability to disable spilling in UnsafeShuffleExternalSorter.
There's no obvious use-case for allowing users to disable spark.shuffle.spill and run out of memory. Because this configuration isn't deprecated as of this patch, I've added code to log a warning to let users know if their preference will be ignored by the new shuffle manager.
Configuration menu - View commit details
-
Copy full SHA for 6276168 - Browse repository at this point
Copy the full SHA 6276168View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4a2c785 - Browse repository at this point
Copy the full SHA 4a2c785View commit details -
Configuration menu - View commit details
-
Copy full SHA for e3b8855 - Browse repository at this point
Copy the full SHA e3b8855View commit details -
Configuration menu - View commit details
-
Copy full SHA for c2ce78e - Browse repository at this point
Copy the full SHA c2ce78eView commit details -
Merge remote-tracking branch 'origin/master' into unsafe-sort
Conflicts: project/MimaExcludes.scala
Configuration menu - View commit details
-
Copy full SHA for d5779c6 - Browse repository at this point
Copy the full SHA d5779c6View commit details -
Track time spend closing / flushing files; split TimeTrackingOutputSt…
…ream into separate file.
Configuration menu - View commit details
-
Copy full SHA for 5e189c6 - Browse repository at this point
Copy the full SHA 5e189c6View commit details -
Configuration menu - View commit details
-
Copy full SHA for df07699 - Browse repository at this point
Copy the full SHA df07699View commit details -
Configuration menu - View commit details
-
Copy full SHA for de40b9d - Browse repository at this point
Copy the full SHA de40b9dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4023fa4 - Browse repository at this point
Copy the full SHA 4023fa4View commit details
Commits on May 13, 2015
-
Configuration menu - View commit details
-
Copy full SHA for 51812a7 - Browse repository at this point
Copy the full SHA 51812a7View commit details -
Fix some bugs in the address packing code.
The problem is that TaskMemoryManager expects offsets to include the page base address whereas PackedRecordPointer did not.
Configuration menu - View commit details
-
Copy full SHA for 52a9981 - Browse repository at this point
Copy the full SHA 52a9981View commit details -
Fix deserialization of JavaSerializer instances.
This caused a failure in a new test; this problem occurs when calls ShuffledRDD.setSerializer() with a JavaSerializer.
Configuration menu - View commit details
-
Copy full SHA for d494ffe - Browse repository at this point
Copy the full SHA d494ffeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7610f2f - Browse repository at this point
Copy the full SHA 7610f2fView commit details -
Configuration menu - View commit details
-
Copy full SHA for ef0a86e - Browse repository at this point
Copy the full SHA ef0a86eView commit details