Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-7351][Streaming][Docs] Add spark.streaming.ui.retainedBatches to docs #5899

Closed
wants to merge 1 commit into from
Closed

Conversation

zsxwing
Copy link
Member

@zsxwing zsxwing commented May 5, 2015

The default value will be changed to 1000 in #5533. So here I just used 1000.

@SparkQA
Copy link

SparkQA commented May 5, 2015

Test build #31805 has finished for PR 5899 at commit e1ec515.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds no public classes.

@zsxwing
Copy link
Member Author

zsxwing commented May 5, 2015

retest this please.

@SparkQA
Copy link

SparkQA commented May 5, 2015

Test build #31807 has finished for PR 5899 at commit e1ec515.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • abstract class ShuffleHandle(val shuffleId: Int) extends Serializable
    • * class SomethingNotSerializable
    • logDebug(s" + cloning the object $obj of class $
    • abstract class Evaluator extends Params
    • abstract class PipelineStage extends Params with Logging
    • class BinaryClassificationEvaluator extends Evaluator with HasRawPredictionCol with HasLabelCol
    • trait LDAOptimizer
    • class EMLDAOptimizer extends LDAOptimizer
    • class OnlineLDAOptimizer extends LDAOptimizer
    • class SaslEncryption
    • static class EncryptedMessage extends AbstractReferenceCounted implements FileRegion
    • class SaslRpcHandler extends RpcHandler
    • public class SaslServerBootstrap implements TransportServerBootstrap
    • public class SparkSaslClient implements SaslEncryptionBackend
    • public class SparkSaslServer implements SaslEncryptionBackend
    • public class ByteArrayWritableChannel implements WritableByteChannel
    • class ParamGridBuilder(object):
    • abstract class Dialect
    • class DialectException(msg: String, cause: Throwable) extends Exception(msg, cause)
    • case class HiveDatabase(
    • abstract class TableType
    • case class HiveStorageDescriptor(
    • case class HivePartition(
    • case class HiveColumn(name: String, hiveType: String, comment: String)
    • case class HiveTable(
    • trait ClientInterface
    • class ClientWrapper(
    • class IsolatedClientLoader(
    • protected trait ReflectionMagic
    • protected implicit class InstanceMagic(a: Any)
    • protected implicit class StaticMagic(c: Class[_])

@@ -1474,6 +1474,13 @@ Apart from these, the following properties are also available, and may be useful
the new Kafka direct stream API.
</td>
</tr>
<tr>
<td><code>spark.streaming.ui.retainedBatches</code></td>
<td>1000</td>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the only question is whether this was intended to be exposed to users or not. What's your argument for that? This should be 100, and changed to 1000 in your other PR if this goes in.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just like spark.ui.retainedJobs and spark.ui.retainedStages and should be exposed. I think we can merge this after #5533.

@zsxwing
Copy link
Member Author

zsxwing commented May 5, 2015

#5533 is merged. So this one is ready to go.

@tdas
Copy link
Contributor

tdas commented May 5, 2015

LGTM. Merging.

@asfgit asfgit closed this in fec7b29 May 5, 2015
asfgit pushed a commit that referenced this pull request May 5, 2015
…s to docs

The default value will be changed to `1000` in #5533. So here I just used `1000`.

Author: zsxwing <zsxwing@gmail.com>

Closes #5899 from zsxwing/SPARK-7351 and squashes the following commits:

e1ec515 [zsxwing] [SPARK-7351][Streaming][Docs] Add spark.streaming.ui.retainedBatches to docs

(cherry picked from commit fec7b29)
Signed-off-by: Tathagata Das <tathagata.das1565@gmail.com>
@zsxwing zsxwing deleted the SPARK-7351 branch May 5, 2015 20:46
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request May 28, 2015
…s to docs

The default value will be changed to `1000` in apache#5533. So here I just used `1000`.

Author: zsxwing <zsxwing@gmail.com>

Closes apache#5899 from zsxwing/SPARK-7351 and squashes the following commits:

e1ec515 [zsxwing] [SPARK-7351][Streaming][Docs] Add spark.streaming.ui.retainedBatches to docs
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request Jun 12, 2015
…s to docs

The default value will be changed to `1000` in apache#5533. So here I just used `1000`.

Author: zsxwing <zsxwing@gmail.com>

Closes apache#5899 from zsxwing/SPARK-7351 and squashes the following commits:

e1ec515 [zsxwing] [SPARK-7351][Streaming][Docs] Add spark.streaming.ui.retainedBatches to docs
nemccarthy pushed a commit to nemccarthy/spark that referenced this pull request Jun 19, 2015
…s to docs

The default value will be changed to `1000` in apache#5533. So here I just used `1000`.

Author: zsxwing <zsxwing@gmail.com>

Closes apache#5899 from zsxwing/SPARK-7351 and squashes the following commits:

e1ec515 [zsxwing] [SPARK-7351][Streaming][Docs] Add spark.streaming.ui.retainedBatches to docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants