-
Notifications
You must be signed in to change notification settings - Fork 28.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-7351][Streaming][Docs] Add spark.streaming.ui.retainedBatches to docs #5899
Conversation
Test build #31805 has finished for PR 5899 at commit
|
retest this please. |
Test build #31807 has finished for PR 5899 at commit
|
@@ -1474,6 +1474,13 @@ Apart from these, the following properties are also available, and may be useful | |||
the new Kafka direct stream API. | |||
</td> | |||
</tr> | |||
<tr> | |||
<td><code>spark.streaming.ui.retainedBatches</code></td> | |||
<td>1000</td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the only question is whether this was intended to be exposed to users or not. What's your argument for that? This should be 100, and changed to 1000 in your other PR if this goes in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just like spark.ui.retainedJobs
and spark.ui.retainedStages
and should be exposed. I think we can merge this after #5533.
#5533 is merged. So this one is ready to go. |
LGTM. Merging. |
…s to docs The default value will be changed to `1000` in #5533. So here I just used `1000`. Author: zsxwing <zsxwing@gmail.com> Closes #5899 from zsxwing/SPARK-7351 and squashes the following commits: e1ec515 [zsxwing] [SPARK-7351][Streaming][Docs] Add spark.streaming.ui.retainedBatches to docs (cherry picked from commit fec7b29) Signed-off-by: Tathagata Das <tathagata.das1565@gmail.com>
…s to docs The default value will be changed to `1000` in apache#5533. So here I just used `1000`. Author: zsxwing <zsxwing@gmail.com> Closes apache#5899 from zsxwing/SPARK-7351 and squashes the following commits: e1ec515 [zsxwing] [SPARK-7351][Streaming][Docs] Add spark.streaming.ui.retainedBatches to docs
…s to docs The default value will be changed to `1000` in apache#5533. So here I just used `1000`. Author: zsxwing <zsxwing@gmail.com> Closes apache#5899 from zsxwing/SPARK-7351 and squashes the following commits: e1ec515 [zsxwing] [SPARK-7351][Streaming][Docs] Add spark.streaming.ui.retainedBatches to docs
…s to docs The default value will be changed to `1000` in apache#5533. So here I just used `1000`. Author: zsxwing <zsxwing@gmail.com> Closes apache#5899 from zsxwing/SPARK-7351 and squashes the following commits: e1ec515 [zsxwing] [SPARK-7351][Streaming][Docs] Add spark.streaming.ui.retainedBatches to docs
The default value will be changed to
1000
in #5533. So here I just used1000
.