[SPARK-6812][SparkR] filter() on DataFrame does not work as expected. #5938

sun-rui · 2015-05-06T09:48:45Z

According to the R manual: https://stat.ethz.ch/R-manual/R-devel/library/base/html/Startup.html,
" if a function .First is found on the search path, it is executed as .First(). Finally, function .First.sys() in the base package is run. This calls require to attach the default packages specified by options("defaultPackages")."
In .First() in profile/shell.R, we load SparkR package. This means SparkR package is loaded before default packages. If there are same names in default packages, they will overwrite those in SparkR. This is why filter() in SparkR is masked by filter() in stats, which is usually in the default package list.
We need to make sure SparkR is loaded after default packages. The solution is to append SparkR to default packages, instead of loading SparkR in .First().

BTW, I'd like to discuss our policy on how to solve name conflict. Previously, we rename API names from Scala API if there is name conflict with base or other commonly-used packages. However, from long term perspective, this is not good for API stability, because we can't predict name conflicts, for example, if in the future a name added in base package conflicts with an API in SparkR? So the better policy is to keep API name same as Scala's without worrying about name conflicts. When users use SparkR, they should load SparkR as last package, so that all API names are effective. Use can explicitly use :: to refer to hidden names from other packages. If we agree on this, I can submit a JIRA issue to change back some rename API methods, for example, DataFrame.sortDF().

AmplabJenkins · 2015-05-06T09:52:09Z

Merged build triggered.

AmplabJenkins · 2015-05-06T09:52:15Z

Merged build started.

SparkQA · 2015-05-06T09:54:01Z

Test build #31967 has started for PR 5938 at commit b569145.

shivaram · 2015-05-06T16:32:53Z

For some reason Jenkins didn't post the test result. Lets try again
Jenkins, retest this please

shivaram · 2015-05-06T16:33:13Z

Thanks @sun-rui -- Lets move the naming policy discussion to the JIRA 6812

shivaram · 2015-05-06T16:57:50Z

@shaneknapp could you check why Jenkins doesn't retest this ? Am I not on the whitelist anymore ?

pwendell · 2015-05-06T17:32:26Z

I think github API is just failing:

 > api_response: {"message": "No server is currently available to service your request. Sorry about that. Please try resubmitting your request and contact us if the problem persists."}

shaneknapp · 2015-05-06T17:47:46Z

@shivaram -- you're an admin. looks like what patrick is saying is the cause.

jenkins, test this please

shivaram · 2015-05-06T20:22:44Z

jenkins, retest this please

(third time lucky ?)

shaneknapp · 2015-05-06T20:35:20Z

jenkins, test this please

AmplabJenkins · 2015-05-06T20:37:12Z

Merged build triggered.

AmplabJenkins · 2015-05-06T20:37:21Z

Merged build started.

SparkQA · 2015-05-06T20:39:19Z

Test build #32024 has started for PR 5938 at commit b569145.

SparkQA · 2015-05-06T21:40:01Z

Test build #32024 has finished for PR 5938 at commit b569145.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

AmplabJenkins · 2015-05-06T21:40:05Z

Merged build finished. Test FAILed.

AmplabJenkins · 2015-05-06T21:40:05Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32024/
Test FAILed.

shivaram · 2015-05-06T21:42:22Z

Tests are failing because of a hive test issue. I'll wait till that get resolved before re-testing. I tried the change locally and it works fine. LGTM

shivaram · 2015-05-06T21:59:40Z

Jenkins, retest this please

AmplabJenkins · 2015-05-06T22:02:11Z

Merged build triggered.

AmplabJenkins · 2015-05-06T22:02:21Z

Merged build started.

SparkQA · 2015-05-06T22:02:33Z

Test build #32035 has started for PR 5938 at commit b569145.

SparkQA · 2015-05-06T23:12:29Z

Test build #32035 has finished for PR 5938 at commit b569145.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

AmplabJenkins · 2015-05-06T23:12:35Z

Merged build finished. Test FAILed.

AmplabJenkins · 2015-05-06T23:12:35Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32035/
Test FAILed.

shivaram · 2015-05-06T23:36:35Z

Sigh - random test failures.

Jenkins, retest this please

shivaram · 2015-05-06T23:55:32Z

Jenkins, retest this please

cc @shaneknapp

shaneknapp · 2015-05-07T00:30:01Z

sigh.

shaneknapp · 2015-05-07T00:30:09Z

jenkins, test this please

shaneknapp · 2015-05-07T00:30:21Z

(i think we're due a jenkins restart tomorrow morning)

AmplabJenkins · 2015-05-07T00:32:11Z

Merged build triggered.

AmplabJenkins · 2015-05-07T00:32:17Z

Merged build started.

shaneknapp · 2015-05-07T00:35:33Z

@shivaram -- i seriously have no clue as to what's going on... you're an overall GHPRB admin for amplab jenkins, as well as for the spark PRB (as am i). anyways, after the spate of errors over the last week (post-power-outage), i'll schedule an emergency restart for tomorrow morning.

shaneknapp · 2015-05-07T00:39:32Z

@shivaram -- can you try and trigger another build? i've increased the log chattiness and hopefully i can see what's happening now.

AmplabJenkins · 2015-05-07T00:47:21Z

Merged build finished. Test FAILed.

AmplabJenkins · 2015-05-07T00:47:21Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32054/
Test FAILed.

shivaram · 2015-05-07T01:34:30Z

Jenkins, retest this please

AmplabJenkins · 2015-05-07T01:37:11Z

Merged build triggered.

AmplabJenkins · 2015-05-07T01:37:18Z

Merged build started.

SparkQA · 2015-05-07T01:37:31Z

Test build #32061 has started for PR 5938 at commit b569145.

shaneknapp · 2015-05-07T01:37:47Z

well, it works now... i didn't actually touch a thing! :\

SparkQA · 2015-05-07T03:20:20Z

Test build #32061 has finished for PR 5938 at commit b569145.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

AmplabJenkins · 2015-05-07T03:20:25Z

Merged build finished. Test PASSed.

AmplabJenkins · 2015-05-07T03:20:26Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32061/
Test PASSed.

shivaram · 2015-05-07T05:47:51Z

Thanks @sun-rui - Merging this.

According to the R manual: https://stat.ethz.ch/R-manual/R-devel/library/base/html/Startup.html, " if a function .First is found on the search path, it is executed as .First(). Finally, function .First.sys() in the base package is run. This calls require to attach the default packages specified by options("defaultPackages")." In .First() in profile/shell.R, we load SparkR package. This means SparkR package is loaded before default packages. If there are same names in default packages, they will overwrite those in SparkR. This is why filter() in SparkR is masked by filter() in stats, which is usually in the default package list. We need to make sure SparkR is loaded after default packages. The solution is to append SparkR to default packages, instead of loading SparkR in .First(). BTW, I'd like to discuss our policy on how to solve name conflict. Previously, we rename API names from Scala API if there is name conflict with base or other commonly-used packages. However, from long term perspective, this is not good for API stability, because we can't predict name conflicts, for example, if in the future a name added in base package conflicts with an API in SparkR? So the better policy is to keep API name same as Scala's without worrying about name conflicts. When users use SparkR, they should load SparkR as last package, so that all API names are effective. Use can explicitly use :: to refer to hidden names from other packages. If we agree on this, I can submit a JIRA issue to change back some rename API methods, for example, DataFrame.sortDF(). Author: Sun Rui <rui.sun@intel.com> Closes #5938 from sun-rui/SPARK-6812 and squashes the following commits: b569145 [Sun Rui] [SPARK-6812][SparkR] filter() on DataFrame does not work as expected. (cherry picked from commit 9cfa9a5) Signed-off-by: Shivaram Venkataraman <shivaram@cs.berkeley.edu>

According to the R manual: https://stat.ethz.ch/R-manual/R-devel/library/base/html/Startup.html, " if a function .First is found on the search path, it is executed as .First(). Finally, function .First.sys() in the base package is run. This calls require to attach the default packages specified by options("defaultPackages")." In .First() in profile/shell.R, we load SparkR package. This means SparkR package is loaded before default packages. If there are same names in default packages, they will overwrite those in SparkR. This is why filter() in SparkR is masked by filter() in stats, which is usually in the default package list. We need to make sure SparkR is loaded after default packages. The solution is to append SparkR to default packages, instead of loading SparkR in .First(). BTW, I'd like to discuss our policy on how to solve name conflict. Previously, we rename API names from Scala API if there is name conflict with base or other commonly-used packages. However, from long term perspective, this is not good for API stability, because we can't predict name conflicts, for example, if in the future a name added in base package conflicts with an API in SparkR? So the better policy is to keep API name same as Scala's without worrying about name conflicts. When users use SparkR, they should load SparkR as last package, so that all API names are effective. Use can explicitly use :: to refer to hidden names from other packages. If we agree on this, I can submit a JIRA issue to change back some rename API methods, for example, DataFrame.sortDF(). Author: Sun Rui <rui.sun@intel.com> Closes apache#5938 from sun-rui/SPARK-6812 and squashes the following commits: b569145 [Sun Rui] [SPARK-6812][SparkR] filter() on DataFrame does not work as expected.

[SPARK-6812][SparkR] filter() on DataFrame does not work as expected.

b569145

asfgit closed this in 9cfa9a5 May 7, 2015

[SPARK-6812][SparkR] filter() on DataFrame does not work as expected. #5938

[SPARK-6812][SparkR] filter() on DataFrame does not work as expected. #5938

Conversation

sun-rui commented May 6, 2015

AmplabJenkins commented May 6, 2015

AmplabJenkins commented May 6, 2015

SparkQA commented May 6, 2015

shivaram commented May 6, 2015

shivaram commented May 6, 2015

shivaram commented May 6, 2015

pwendell commented May 6, 2015

shaneknapp commented May 6, 2015

shivaram commented May 6, 2015

shaneknapp commented May 6, 2015

AmplabJenkins commented May 6, 2015

AmplabJenkins commented May 6, 2015

SparkQA commented May 6, 2015

SparkQA commented May 6, 2015

AmplabJenkins commented May 6, 2015

AmplabJenkins commented May 6, 2015

shivaram commented May 6, 2015

shivaram commented May 6, 2015

AmplabJenkins commented May 6, 2015

AmplabJenkins commented May 6, 2015

SparkQA commented May 6, 2015

SparkQA commented May 6, 2015

AmplabJenkins commented May 6, 2015

AmplabJenkins commented May 6, 2015

shivaram commented May 6, 2015

shivaram commented May 6, 2015

shaneknapp commented May 7, 2015

shaneknapp commented May 7, 2015

shaneknapp commented May 7, 2015

AmplabJenkins commented May 7, 2015

AmplabJenkins commented May 7, 2015

shaneknapp commented May 7, 2015

shaneknapp commented May 7, 2015

AmplabJenkins commented May 7, 2015

AmplabJenkins commented May 7, 2015

shivaram commented May 7, 2015

AmplabJenkins commented May 7, 2015

AmplabJenkins commented May 7, 2015

SparkQA commented May 7, 2015

shaneknapp commented May 7, 2015

SparkQA commented May 7, 2015

AmplabJenkins commented May 7, 2015

AmplabJenkins commented May 7, 2015

shivaram commented May 7, 2015