Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-6093] [MLLIB] Add RegressionMetrics in PySpark/MLlib #5941

Closed
wants to merge 2 commits into from
Closed

[SPARK-6093] [MLLIB] Add RegressionMetrics in PySpark/MLlib #5941

wants to merge 2 commits into from

Conversation

yanboliang
Copy link
Contributor

@AmplabJenkins
Copy link

Merged build triggered.

@AmplabJenkins
Copy link

Merged build started.

@SparkQA
Copy link

SparkQA commented May 6, 2015

Test build #31978 has started for PR 5941 at commit aac3bc5.

@SparkQA
Copy link

SparkQA commented May 6, 2015

Test build #31978 has finished for PR 5941 at commit aac3bc5.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class RegressionMetrics(JavaModelWrapper):

@AmplabJenkins
Copy link

Merged build finished. Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31978/
Test PASSed.

mengxr
mengxr reviewed May 6, 2015
View reviewed changes
python/pyspark/mllib/evaluation.py
java_model = java_class(df._jdf)
super(RegressionMetrics, self).__init__(java_model)

def explainedVariance(self):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think it is better if we mark it as @property? I didn't do that for BinaryClassificationMetrics, but we still have time to make this change.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I agree. I will do it for both.

@AmplabJenkins
Copy link

Merged build triggered.

@AmplabJenkins
Copy link

Merged build started.

@SparkQA
Copy link

SparkQA commented May 7, 2015

Test build #32120 has started for PR 5941 at commit 6934af3.

@mengxr
Copy link
Contributor

mengxr commented May 7, 2015

LGTM pending Jenkins.

@SparkQA
Copy link

SparkQA commented May 7, 2015

Test build #32120 has finished for PR 5941 at commit 6934af3.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Merged build finished. Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32120/
Test PASSed.

asfgit pushed a commit that referenced this pull request May 7, 2015
@yanboliang @mengxr
[SPARK-6093] [MLLIB] Add RegressionMetrics in PySpark/MLlib
ef835dc 
https://issues.apache.org/jira/browse/SPARK-6093

Author: Yanbo Liang <ybliang8@gmail.com>

Closes #5941 from yanboliang/spark-6093 and squashes the following commits:

6934af3 [Yanbo Liang] change to @Property
aac3bc5 [Yanbo Liang] Add RegressionMetrics in PySpark/MLlib

(cherry picked from commit 1712a7c)
Signed-off-by: Xiangrui Meng <meng@databricks.com>
@asfgit asfgit closed this in 1712a7c May 7, 2015
@mengxr
Copy link
Contributor

mengxr commented May 7, 2015

Merged into master and branch-1.4. Thanks! Would you like to port other evaluation metrics to Python? MulticlassMetrics and RankingMetrics are quite important.

@yanboliang
Copy link
Contributor Author

@mengxr , OK, I will take them.

jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request May 28, 2015
@yanboliang @jeanlyn
[SPARK-6093] [MLLIB] Add RegressionMetrics in PySpark/MLlib
6950ea0 
https://issues.apache.org/jira/browse/SPARK-6093

Author: Yanbo Liang <ybliang8@gmail.com>

Closes apache#5941 from yanboliang/spark-6093 and squashes the following commits:

6934af3 [Yanbo Liang] change to @Property
aac3bc5 [Yanbo Liang] Add RegressionMetrics in PySpark/MLlib
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request Jun 12, 2015
@yanboliang @jeanlyn
[SPARK-6093] [MLLIB] Add RegressionMetrics in PySpark/MLlib
daf4298 
https://issues.apache.org/jira/browse/SPARK-6093

Author: Yanbo Liang <ybliang8@gmail.com>

Closes apache#5941 from yanboliang/spark-6093 and squashes the following commits:

6934af3 [Yanbo Liang] change to @Property
aac3bc5 [Yanbo Liang] Add RegressionMetrics in PySpark/MLlib
nemccarthy pushed a commit to nemccarthy/spark that referenced this pull request Jun 19, 2015
@yanboliang @nemccarthy
[SPARK-6093] [MLLIB] Add RegressionMetrics in PySpark/MLlib
e45b7ee 
https://issues.apache.org/jira/browse/SPARK-6093

Author: Yanbo Liang <ybliang8@gmail.com>

Closes apache#5941 from yanboliang/spark-6093 and squashes the following commits:

6934af3 [Yanbo Liang] change to @Property
aac3bc5 [Yanbo Liang] Add RegressionMetrics in PySpark/MLlib
@yanboliang yanboliang deleted the spark-6093 branch June 26, 2015 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@yanboliang @AmplabJenkins @SparkQA @mengxr