Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-4556] [BUILD] binary distribution assembly can't run in local mode #6186

Closed
wants to merge 2 commits into from

Conversation

srowen
Copy link
Member

@srowen srowen commented May 15, 2015

Add note on building a runnable distribution with make-distribution.sh

@AmplabJenkins
Copy link

Merged build triggered.

@AmplabJenkins
Copy link

Merged build started.

@SparkQA
Copy link

SparkQA commented May 15, 2015

Test build #32822 has started for PR 6186 at commit 9fa7883.

to be runnable, use `make-distribution.sh` in the project root directory. It can be configured
with Maven profile settings and so on like the direct Maven build. Example:

./make-distribution.sh --name custom-spark --tgz -Phadoop-2.4 -Pyarn
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a closing "for more information on usage run ./make-distribution.sh --help"

@AmplabJenkins
Copy link

Merged build triggered.

@AmplabJenkins
Copy link

Merged build started.

@SparkQA
Copy link

SparkQA commented May 15, 2015

Test build #32824 has started for PR 6186 at commit 4002966.

@SparkQA
Copy link

SparkQA commented May 15, 2015

Test build #32822 has finished for PR 6186 at commit 9fa7883.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Merged build finished. Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32822/
Test PASSed.

@SparkQA
Copy link

SparkQA commented May 15, 2015

Test build #32824 has finished for PR 6186 at commit 4002966.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Merged build finished. Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32824/
Test PASSed.

@andrewor14
Copy link
Contributor

@pwendell do we want to document the make-distribution script explicitly? I remember there's some discussion on that.

@pwendell
Copy link
Contributor

Yeah I think so - we've had this around for a long time and I use it heavily as part of releases. I've actually made some effort to support backwards compatibility in this script over the years, so IMO it's something I'm prepared to keep supporting.

@vanzin
Copy link
Contributor

vanzin commented May 15, 2015

This is great, but should we also use the opportunity to get rid of that "bigtop-dist" profile altogether? It generates broken artifacts, as shown in the bug.

@busbey
Copy link

busbey commented May 15, 2015

Does that profile get used by BigTop for packaging spark downstream?

@vanzin
Copy link
Contributor

vanzin commented May 15, 2015

Does that profile get used by BigTop for packaging spark downstream?

Good question; but if they use it, they must have a lot of extra code to deal with the broken tarball it generates. But yes, maybe better to leave that for a separate change and give the bigtop guys a heads up.

asfgit pushed a commit that referenced this pull request May 16, 2015
…mode

Add note on building a runnable distribution with make-distribution.sh

Author: Sean Owen <sowen@cloudera.com>

Closes #6186 from srowen/SPARK-4556 and squashes the following commits:

4002966 [Sean Owen] Add pointer to --help flag
9fa7883 [Sean Owen] Add note on building a runnable distribution with make-distribution.sh

(cherry picked from commit 1fd3381)
Signed-off-by: Sean Owen <sowen@cloudera.com>
@asfgit asfgit closed this in 1fd3381 May 16, 2015
@srowen srowen deleted the SPARK-4556 branch May 19, 2015 07:56
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request May 28, 2015
…mode

Add note on building a runnable distribution with make-distribution.sh

Author: Sean Owen <sowen@cloudera.com>

Closes apache#6186 from srowen/SPARK-4556 and squashes the following commits:

4002966 [Sean Owen] Add pointer to --help flag
9fa7883 [Sean Owen] Add note on building a runnable distribution with make-distribution.sh
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request Jun 12, 2015
…mode

Add note on building a runnable distribution with make-distribution.sh

Author: Sean Owen <sowen@cloudera.com>

Closes apache#6186 from srowen/SPARK-4556 and squashes the following commits:

4002966 [Sean Owen] Add pointer to --help flag
9fa7883 [Sean Owen] Add note on building a runnable distribution with make-distribution.sh
nemccarthy pushed a commit to nemccarthy/spark that referenced this pull request Jun 19, 2015
…mode

Add note on building a runnable distribution with make-distribution.sh

Author: Sean Owen <sowen@cloudera.com>

Closes apache#6186 from srowen/SPARK-4556 and squashes the following commits:

4002966 [Sean Owen] Add pointer to --help flag
9fa7883 [Sean Owen] Add note on building a runnable distribution with make-distribution.sh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
7 participants