Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Spark-7446][MLLIB] Add inverse transform for string indexer #6339

Closed
wants to merge 27 commits into from
Closed

[Spark-7446][MLLIB] Add inverse transform for string indexer #6339

wants to merge 27 commits into from

Commits on Jul 7, 2015

  1. Some progress

    @holdenk
    holdenk committed Jul 7, 2015
    Configuration menu
    Copy the full SHA
    bb16a6a View commit details
    Browse the repository at this point in the history

  2. Finish reverse part and add a test :)

    @holdenk
    holdenk committed Jul 7, 2015
    Configuration menu
    Copy the full SHA
    78b28c1 View commit details
    Browse the repository at this point in the history

  3. fix long line

    @holdenk
    holdenk committed Jul 7, 2015
    Configuration menu
    Copy the full SHA
    88779c1 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2015

  1. Instead of using a private inverse transform, add an invert function … 

    …so we can use it in a pipeline
    @holdenk
    holdenk committed Jul 8, 2015
    Configuration menu
    Copy the full SHA
    557bef8 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2015

  1. Some WIP refactoring based on jkbradley's CR feedback. Definite work-… 

    …in-progress
    @holdenk
    holdenk committed Jul 28, 2015
    Configuration menu
    Copy the full SHA
    c3fdee1 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into SPARK-7446-inverse-transform-for-string-in… 

    …dexer
    @holdenk
    holdenk committed Jul 28, 2015
    Configuration menu
    Copy the full SHA
    e8bf3ad View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2015

  1. Make the inverse string indexer into a transformer (still needs test … 

    …updates but compiles)
    @holdenk
    holdenk committed Jul 29, 2015
    Configuration menu
    Copy the full SHA
    d4bcb20 View commit details
    Browse the repository at this point in the history

  2. Add an invert method

    @holdenk
    holdenk committed Jul 29, 2015
    Configuration menu
    Copy the full SHA
    16cc3c3 View commit details
    Browse the repository at this point in the history

  3. Fix test to supply cols as per new invert method

    @holdenk
    holdenk committed Jul 29, 2015
    Configuration menu
    Copy the full SHA
    a42d773 View commit details
    Browse the repository at this point in the history

  4. Read the metadata correctly, use the array, pass the test

    @holdenk
    holdenk committed Jul 29, 2015
    Configuration menu
    Copy the full SHA
    ecc65e0 View commit details
    Browse the repository at this point in the history

  5. Add explicit type for invert function

    @holdenk
    holdenk committed Jul 29, 2015
    Configuration menu
    Copy the full SHA
    03ebf95 View commit details
    Browse the repository at this point in the history

  6. Add Experimental tag and some scaladocs. Also don't require that the … 

    …inputCol has the metadata on it, instead have the labelsCol specified when creating the inverse.
    @holdenk
    holdenk committed Jul 29, 2015
    Configuration menu
    Copy the full SHA
    ebed932 View commit details
    Browse the repository at this point in the history

  7. CR feedback

    @holdenk
    holdenk committed Jul 29, 2015
    Configuration menu
    Copy the full SHA
    f3e0c64 View commit details
    Browse the repository at this point in the history

  8. Add an inverse test using only meta data, pass labels when calling in… 

    …verse method
    @holdenk
    holdenk committed Jul 29, 2015
    Configuration menu
    Copy the full SHA
    5aa38bf View commit details
    Browse the repository at this point in the history

  9. Update scaladoc since we don't have labelsCol anymore

    @holdenk
    holdenk committed Jul 29, 2015
    Configuration menu
    Copy the full SHA
    868b1a9 View commit details
    Browse the repository at this point in the history

  10. Add a labels param

    @holdenk
    holdenk committed Jul 29, 2015
    Configuration menu
    Copy the full SHA
    7464019 View commit details
    Browse the repository at this point in the history

  11. Use the labels param in StringIndexerInverse

    @holdenk
    holdenk committed Jul 29, 2015
    Configuration menu
    Copy the full SHA
    8450d0b View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2015

  1. Make labels a local param for StringIndexerInverse

    @holdenk
    holdenk committed Jul 30, 2015
    Configuration menu
    Copy the full SHA
    71e8d66 View commit details
    Browse the repository at this point in the history

  2. Use default copy

    @holdenk
    holdenk committed Jul 30, 2015
    Configuration menu
    Copy the full SHA
    1987b95 View commit details
    Browse the repository at this point in the history

  3. CR feedback (remove old constructor, add a note about use of setLabels)

    @holdenk
    holdenk committed Jul 30, 2015
    Configuration menu
    Copy the full SHA
    a60c0e3 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2015

  1. Fix comment styles, use empty array as the default, etc.

    @holdenk
    holdenk committed Jul 31, 2015
    Configuration menu
    Copy the full SHA
    4f06c59 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into SPARK-7446-inverse-transform-for-string-in… 

    …dexer
    @holdenk
    holdenk committed Jul 31, 2015
    Configuration menu
    Copy the full SHA
    64dd3a3 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into SPARK-7446-inverse-transform-for-string-in… 

    …dexer
    @holdenk
    holdenk committed Jul 31, 2015
    Configuration menu
    Copy the full SHA
    21c8cfa View commit details
    Browse the repository at this point in the history

  4. use Array.empty

    @holdenk
    holdenk committed Jul 31, 2015
    Configuration menu
    Copy the full SHA
    9e241d8 View commit details
    Browse the repository at this point in the history

  5. Setting the default needs to come after the value gets defined

    @holdenk
    holdenk committed Jul 31, 2015
    Configuration menu
    Copy the full SHA
    6a38edb View commit details
    Browse the repository at this point in the history

  6. Update the labels param to have the metadata note

    @holdenk
    holdenk committed Jul 31, 2015
    Configuration menu
    Copy the full SHA
    b9cffb6 View commit details
    Browse the repository at this point in the history

  7. scala style comment fix

    @holdenk
    holdenk committed Jul 31, 2015
    Configuration menu
    Copy the full SHA
    7cdf915 View commit details
    Browse the repository at this point in the history