New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-7577][ML][doc] add bucketizer doc #6451
Conversation
Test build #33641 has finished for PR 6451 at commit
|
import org.apache.spark.ml.feature.Bucketizer | ||
import org.apache.spark.sql.DataFrame | ||
|
||
// Since we know the bounds of data, there is no need to add -inf and inf. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you actually have these examples use -inf and inf? I'm afraid some people might copy the code without thinking and be confused when they get out-of-bounds errors.
@yinxusen Other than those comments, these look good. Thanks! |
@jkbradley Fixed. |
Test build #33651 has finished for PR 6451 at commit
|
LGTM, merging into master and branch-1.4 Thank you! |
CC jkbradley Author: Xusen Yin <yinxusen@gmail.com> Closes #6451 from yinxusen/SPARK-7577 and squashes the following commits: e2dc32e [Xusen Yin] rename colums e350e49 [Xusen Yin] add all demos 006ddf1 [Xusen Yin] add java test 3238481 [Xusen Yin] add bucketizer (cherry picked from commit 1bd63e8) Signed-off-by: Joseph K. Bradley <joseph@databricks.com>
CC jkbradley Author: Xusen Yin <yinxusen@gmail.com> Closes apache#6451 from yinxusen/SPARK-7577 and squashes the following commits: e2dc32e [Xusen Yin] rename colums e350e49 [Xusen Yin] add all demos 006ddf1 [Xusen Yin] add java test 3238481 [Xusen Yin] add bucketizer
CC jkbradley Author: Xusen Yin <yinxusen@gmail.com> Closes apache#6451 from yinxusen/SPARK-7577 and squashes the following commits: e2dc32e [Xusen Yin] rename colums e350e49 [Xusen Yin] add all demos 006ddf1 [Xusen Yin] add java test 3238481 [Xusen Yin] add bucketizer
CC @jkbradley