Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-8025][Streaming]Add JavaDoc style deprecation for deprecated Streaming methods #6564

Closed
wants to merge 1 commit into from
Closed

[SPARK-8025][Streaming]Add JavaDoc style deprecation for deprecated Streaming methods #6564

wants to merge 1 commit into from

Conversation

zsxwing
Copy link
Member

@zsxwing zsxwing commented Jun 2, 2015

Scala @deprecated annotation actually doesn't show up in JavaDoc.

@zsxwing
Copy link
Member Author

zsxwing commented Jun 2, 2015

@tdas please take a look

@SparkQA
Copy link

SparkQA commented Jun 2, 2015

Test build #33939 has finished for PR 6564 at commit 2faa2bb.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • case class SortOrder(child: Expression, direction: SortDirection) extends Expression
    • abstract class BinaryMathExpression(f: (Double, Double) => Double, name: String)

@zsxwing
Copy link
Member Author

zsxwing commented Jun 2, 2015

retest this please

@tdas
Copy link
Contributor

tdas commented Jun 2, 2015

LGTM.

@SparkQA
Copy link

SparkQA commented Jun 2, 2015

Test build #33949 has finished for PR 6564 at commit 2faa2bb.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

asfgit pushed a commit that referenced this pull request Jun 2, 2015
@zsxwing @rxin
[SPARK-8025][Streaming]Add JavaDoc style deprecation for deprecated S…
0d21a41 
…treaming methods

Scala `deprecated` annotation actually doesn't show up in JavaDoc.

Author: zsxwing <zsxwing@gmail.com>

Closes #6564 from zsxwing/SPARK-8025 and squashes the following commits:

2faa2bb [zsxwing] Add JavaDoc style deprecation for deprecated Streaming methods

(cherry picked from commit 7f74bb3)
Signed-off-by: Reynold Xin <rxin@databricks.com>
@asfgit asfgit closed this in 7f74bb3 Jun 2, 2015
@zsxwing zsxwing deleted the SPARK-8025 branch June 2, 2015 10:05
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request Jun 12, 2015
@zsxwing @jeanlyn
[SPARK-8025][Streaming]Add JavaDoc style deprecation for deprecated S…
8d61d06 
…treaming methods

Scala `deprecated` annotation actually doesn't show up in JavaDoc.

Author: zsxwing <zsxwing@gmail.com>

Closes apache#6564 from zsxwing/SPARK-8025 and squashes the following commits:

2faa2bb [zsxwing] Add JavaDoc style deprecation for deprecated Streaming methods
nemccarthy pushed a commit to nemccarthy/spark that referenced this pull request Jun 19, 2015
@zsxwing @nemccarthy
[SPARK-8025][Streaming]Add JavaDoc style deprecation for deprecated S…
ab84ebc 
…treaming methods

Scala `deprecated` annotation actually doesn't show up in JavaDoc.

Author: zsxwing <zsxwing@gmail.com>

Closes apache#6564 from zsxwing/SPARK-8025 and squashes the following commits:

2faa2bb [zsxwing] Add JavaDoc style deprecation for deprecated Streaming methods
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@zsxwing @SparkQA @tdas