[SPARK-7996] Deprecate the developer api SparkEnv.actorSystem #6731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -75,7 +75,8 @@ class SparkEnv ( | |||
| val conf: SparkConf) extends Logging { | |||
|
|
|||
| // TODO Remove actorSystem | |||
| val actorSystem = rpcEnv.asInstanceOf[AkkaRpcEnv].actorSystem | |||
| @deprecated("Actor system is no longer supported") | |||
|
Test build #34537 has finished for PR 6731 at commit
|
|
Test build #34538 has finished for PR 6731 at commit
|
| @@ -75,7 +77,8 @@ class SparkEnv ( | |||
| val conf: SparkConf) extends Logging { | |||
|
|
|||
| // TODO Remove actorSystem | |||
| val actorSystem = rpcEnv.asInstanceOf[AkkaRpcEnv].actorSystem | |||
| @deprecated("Actor system is no longer supported as of 1.4") | |||
There was a problem hiding this comment.
i think the idiom for scala deprecation is
@deprecated("Actor system in SparkEnv is no longer supported", "1.4.0")
I can add |
|
Test build #34614 has finished for PR 6731 at commit
|
|
Thanks - merging this in. |
nemccarthy
pushed a commit
to nemccarthy/spark
that referenced
this pull request
Jun 19, 2015
Changed ```SparkEnv.actorSystem``` to be a function such that we can use the deprecated flag with it and added a deprecated message. Author: Ilya Ganelin <ilya.ganelin@capitalone.com> Closes apache#6731 from ilganeli/SPARK-7996 and squashes the following commits: be43817 [Ilya Ganelin] Restored to val 9ed89e7 [Ilya Ganelin] Added a version info for deprecation 9610b08 [Ilya Ganelin] Converted actorSystem to function and added deprecated flag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed
SparkEnv.actorSystemto be a function such that we can use the deprecated flag with it and added a deprecated message.