Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spark-8308] [MLlib] add missing save load for python example #6760

Closed
wants to merge 4 commits into from

Conversation

hhbyyh
Copy link
Contributor

@hhbyyh hhbyyh commented Jun 11, 2015

jira: https://issues.apache.org/jira/browse/SPARK-8308

  1. add some missing save/load in python examples. , LogisticRegression, LinearRegression and NaiveBayes
  2. tune down iterations for MatrixFactorization, since current number will trigger StackOverflow for default java configuration (>1M)

@SparkQA
Copy link

SparkQA commented Jun 11, 2015

Test build #34686 has finished for PR 6760 at commit 3e948dc.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@jkbradley
Copy link
Member

@hhbyyh Can you please make the Scala example use 20 iterations too? Other than that, it looks good.

@SparkQA
Copy link

SparkQA commented Jun 30, 2015

Test build #36082 has finished for PR 6760 at commit 9bd3383.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@hhbyyh
Copy link
Contributor Author

hhbyyh commented Jun 30, 2015

@jkbradley Glad you're back! Just sent an update. Thanks for reviewing.

@jkbradley
Copy link
Member

LGTM merging into master
Thank you!

@asfgit asfgit closed this in 2012913 Jul 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants