[SPARK-8350] [R] Log R unit test output to "unit-tests.log"

[andrewor14]

Right now it's logged to "R-unit-tests.log". Jenkins currently only archives files named "unit-tests.log", and this is what all other modules (e.g. SQL, network, REPL) use.

1. We should be consistent
2. I don't want to reconfigure Jenkins to accept a different file

@shivaram

[shivaram]

This makes sense @andrewor14 -- Does this also get put in R/target/ automatically ? I see python/target in https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34843/artifact/ for example

[andrewor14]

yeah, it should just work

[shivaram]

Cool - LGTM.

[SparkQA]

Test build #34854 has finished for PR 6807 at commit d7b68ae.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds the following public classes (experimental):
  • class JoinedRow extends InternalRow
  • class JoinedRow2 extends InternalRow
  • class JoinedRow3 extends InternalRow
  • class JoinedRow4 extends InternalRow
  • class JoinedRow5 extends InternalRow
  • class JoinedRow6 extends InternalRow
  • class BaseOrdering extends Ordering[InternalRow]

[andrewor14]

Hm, actually the R logs don't appear to be showing up under "Build Archives". I'll look into this later today.

[shivaram]

We could try to make that R/target/unit-tests.log ? But I'm not sure if log4j creates directories if they don't exist. BTW is there a jenkins config option that specifies the files to archive ?

[andrewor14]

Looks like R is a little different from other modules because there's no src/main/resources. I added target in front of the path. Let's see if this works.

[SparkQA]

Test build #34876 has finished for PR 6807 at commit 407c46c.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[shivaram]

@andrewor14 looks like that worked ? I do see a target/unit-tests.log and it contains logs from R unit tests.

[andrewor14]

wait really? I don't: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34876/artifact/

[andrewor14]

Oh, is that what target/unit-tests.log is? I was expecting it to go under R/target/unit-tests.log. That would be more consistent with the other modules. I guess we need to explicitly specify the R directory here because the log4j.properties file is not in R/src/main

[shivaram]

Hmm so I think for the other projects Maven probably care to go into the directory before running tests while it doesn't happen for R. Lets see how the latest one goes

[SparkQA]

Test build #34896 has finished for PR 6807 at commit 96005d2.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[shivaram]

R/target/unit-tests.log exists this time. I guess this is good to merge ?

[andrewor14]

Yup, lgtm. Feel free to merge it.