[SPARK-8362][SQL] Add unit tests for +, -, *, /, % #6813
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @davies We really need to add unit test for all supported data types for each expression. |
rxin
changed the title
|
Test build #34880 has finished for PR 6813 at commit
|
| * @param testFunc a test function that accepts a conversion function to convert an integer | ||
| * into another data type. | ||
| */ | ||
| private def testNumericDataTypes(testFunc: (Int => Any) => Unit): Unit = { |
|
Merging to master! |
|
@rxin Sorry for so many bugs, it's surprise to know that almost no tests for DecimalType. |
| defineCodeGen(ctx, ev, (eval1, eval2) => | ||
| s"(${ctx.javaType(dataType)})($eval1 $symbol $eval2)") | ||
| defineCodeGen(ctx, ev, | ||
| (eval1, eval2) => s"(${ctx.javaType(dataType)})($eval1 $symbol $eval2)") |
There was a problem hiding this comment.
Should we do the same thing(only do type cast for short and byte) for other expressions like UnaryMinus, Divide, etc.?
nemccarthy
pushed a commit
to nemccarthy/spark
that referenced
this pull request
Jun 19, 2015
Added unit tests for all supported data types for: - Add - Subtract - Multiply - Divide - UnaryMinus - Remainder Fixed bugs caught by the unit tests. Author: Reynold Xin <rxin@databricks.com> Closes apache#6813 from rxin/SPARK-8362 and squashes the following commits: fb3fe62 [Reynold Xin] Added Remainder. 3b266ba [Reynold Xin] [SPARK-8362] Add unit tests for +, -, *, /.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added unit tests for all supported data types for:
Fixed bugs caught by the unit tests.