[SPARK-7943][SQL]support DataFrame created by hiveContext can create table to specific database by saveAstable(dbname.tablename) #6868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #35089 has finished for PR 6868 at commit
|
baishuo
changed the title
|
This would be a nice feature to have and thanks for working on it, but I think we need a more holistic solution than what is proposed here (there are a lot of problems with multiple databases: https://issues.apache.org/jira/browse/SPARK-8131). In particular, this issue duplicates the code that resolves a full database name into several places. Big features should probably start with a design instead of a PR. |
| } | ||
|
|
||
| protected[hive] def invalidateTable(tableName: String): Unit = { | ||
| catalog.invalidateTable(catalog.client.currentDatabase, tableName) | ||
| val dbAndTableName = tableName.split("\\.") |
There was a problem hiding this comment.
notice repeated code.
IMHO relative/fully-prefixed tableName logic should be extracted into something like cannonicalTableName(relativeOrPrefixedTableName)
|
I believe this is fixed now and we can close this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support hivecontext.sql(....).saveAsTable(dbname.tablename)