Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-8283][SQL] CreateStruct should not specify the field names #6881

Closed
wants to merge 4 commits into from

Conversation

chenghao-intel
Copy link
Contributor

CreateStruct <=> GenericUDFStruct which always give the default column names for the output struct like (col1, col2...colN)

@chenghao-intel
Copy link
Contributor Author

@YijieSHEN

@yjshen
Copy link
Member

yjshen commented Jun 18, 2015

I prefer to keep the origin column names in the newly created struct, since I think it's more meaningful than col1, col2, col3, and we could just leave the unnamed columns to col1, col2 ..., which is also compatible with Hive's semantic.

I've also made related changes in #6874 to loosen parameter requirements of struct

@chenghao-intel
Copy link
Contributor Author

Ok, sound reasonable to me, closing this PR.

@SparkQA
Copy link

SparkQA commented Jun 18, 2015

Test build #35127 has finished for PR 6881 at commit 35fa5fb.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jun 18, 2015

Test build #35130 has finished for PR 6881 at commit 2efe8ba.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@chenghao-intel chenghao-intel deleted the struct branch July 2, 2015 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants