Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-7715] [mllib] [ml] [doc] Updated MLlib programming guide for release 1.4 #6897

Closed
wants to merge 3 commits into from
Closed

[SPARK-7715] [mllib] [ml] [doc] Updated MLlib programming guide for release 1.4 #6897

wants to merge 3 commits into from

Conversation

jkbradley
Copy link
Member

Reorganized docs a bit. Added migration guides.

Q: Do we want to say more for the 1.3 -> 1.4 migration guide for spark.ml? It would be a lot.

CC: @mengxr

@jkbradley
Copy link
Member Author

Oops, there are formatting mistakes. I'll fix them early tomorrow.

@SparkQA
Copy link

SparkQA commented Jun 19, 2015

Test build #35229 has finished for PR 6897 at commit 6cd5c78.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • * *(Breaking change)* Theapplyandcopymethods for the case class [BoostingStrategy](api/scala/index.html#org.apache.spark.mllib.tree.configuration.BoostingStrategy) have been changed because of a modification to the case class fields. This could be an issue for users who useBoostingStrategyto set GBT parameters.
    • * *(Breaking change)* The return value of [LDA.run](api/scala/index.html#org.apache.spark.mllib.clustering.LDA.run) has changed. It now returns an abstract classLDAModelinstead of the concrete classDistributedLDAModel. The object of typeLDAModelcan still be cast to the appropriate concrete type, which depends on the optimization algorithm.
    • * InDecisionTree, the deprecated class methodtrainhas been removed. (The object/statictrainmethods remain.)

@SparkQA
Copy link

SparkQA commented Jun 19, 2015

Test build #35298 has finished for PR 6897 at commit 4bf26d6.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • * *(Breaking change)* Theapplyandcopymethods for the case class [BoostingStrategy](api/scala/index.html#org.apache.spark.mllib.tree.configuration.BoostingStrategy) have been changed because of a modification to the case class fields. This could be an issue for users who useBoostingStrategyto set GBT parameters.
    • * *(Breaking change)* The return value of [LDA.run](api/scala/index.html#org.apache.spark.mllib.clustering.LDA) has changed. It now returns an abstract classLDAModelinstead of the concrete classDistributedLDAModel. The object of typeLDAModelcan still be cast to the appropriate concrete type, which depends on the optimization algorithm.
    • * InDecisionTree, the deprecated class methodtrainhas been removed. (The object/statictrainmethods remain.)

@jkbradley
Copy link
Member Author

test this please

@SparkQA
Copy link

SparkQA commented Jun 20, 2015

Test build #35342 has finished for PR 6897 at commit 4bf26d6.

  • This patch fails MiMa tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • * *(Breaking change)* Theapplyandcopymethods for the case class [BoostingStrategy](api/scala/index.html#org.apache.spark.mllib.tree.configuration.BoostingStrategy) have been changed because of a modification to the case class fields. This could be an issue for users who useBoostingStrategyto set GBT parameters.
    • * *(Breaking change)* The return value of [LDA.run](api/scala/index.html#org.apache.spark.mllib.clustering.LDA) has changed. It now returns an abstract classLDAModelinstead of the concrete classDistributedLDAModel. The object of typeLDAModelcan still be cast to the appropriate concrete type, which depends on the optimization algorithm.
    • * InDecisionTree, the deprecated class methodtrainhas been removed. (The object/statictrainmethods remain.)

@jkbradley
Copy link
Member Author

test this please

@SparkQA
Copy link

SparkQA commented Jun 20, 2015

Test build #35347 has finished for PR 6897 at commit 4bf26d6.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • * *(Breaking change)* Theapplyandcopymethods for the case class [BoostingStrategy](api/scala/index.html#org.apache.spark.mllib.tree.configuration.BoostingStrategy) have been changed because of a modification to the case class fields. This could be an issue for users who useBoostingStrategyto set GBT parameters.
    • * *(Breaking change)* The return value of [LDA.run](api/scala/index.html#org.apache.spark.mllib.clustering.LDA) has changed. It now returns an abstract classLDAModelinstead of the concrete classDistributedLDAModel. The object of typeLDAModelcan still be cast to the appropriate concrete type, which depends on the optimization algorithm.
    • * InDecisionTree, the deprecated class methodtrainhas been removed. (The object/statictrainmethods remain.)

@jkbradley
Copy link
Member Author

Ping @mengxr What do you think?

@asfgit asfgit closed this in a189442 Jun 21, 2015
asfgit pushed a commit that referenced this pull request Jun 21, 2015
@jkbradley @mengxr
[SPARK-7715] [MLLIB] [ML] [DOC] Updated MLlib programming guide for r…
2a7ea31 
…elease 1.4

Reorganized docs a bit.  Added migration guides.

**Q**: Do we want to say more for the 1.3 -> 1.4 migration guide for ```spark.ml```?  It would be a lot.

CC: mengxr

Author: Joseph K. Bradley <joseph@databricks.com>

Closes #6897 from jkbradley/ml-guide-1.4 and squashes the following commits:

4bf26d6 [Joseph K. Bradley] tiny fix
8085067 [Joseph K. Bradley] fixed spacing/layout issues in ml guide from previous commit in this PR
6cd5c78 [Joseph K. Bradley] Updated MLlib programming guide for release 1.4

(cherry picked from commit a189442)
Signed-off-by: Xiangrui Meng <meng@databricks.com>
@mengxr
Copy link
Contributor

mengxr commented Jun 21, 2015

LGTM. We don't need to mention detailed 1.3 -> 1.4 changes. Merged into master and branch-1.4. Thanks!

nemccarthy pushed a commit to nemccarthy/spark that referenced this pull request Jun 22, 2015
@jkbradley @nemccarthy
[SPARK-7715] [MLLIB] [ML] [DOC] Updated MLlib programming guide for r…
bba4bfc 
…elease 1.4

Reorganized docs a bit.  Added migration guides.

**Q**: Do we want to say more for the 1.3 -> 1.4 migration guide for ```spark.ml```?  It would be a lot.

CC: mengxr

Author: Joseph K. Bradley <joseph@databricks.com>

Closes apache#6897 from jkbradley/ml-guide-1.4 and squashes the following commits:

4bf26d6 [Joseph K. Bradley] tiny fix
8085067 [Joseph K. Bradley] fixed spacing/layout issues in ml guide from previous commit in this PR
6cd5c78 [Joseph K. Bradley] Updated MLlib programming guide for release 1.4

(cherry picked from commit a189442)
Signed-off-by: Xiangrui Meng <meng@databricks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@jkbradley @SparkQA @mengxr