-
Notifications
You must be signed in to change notification settings - Fork 28.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-8431][SparkR] Add in operator to DataFrame Column in SparkR #6941
Conversation
@shivaram Could you review it when you have time? Thanks! |
Test build #35487 has finished for PR 6941 at commit
|
@@ -91,6 +91,16 @@ createOperator <- function(op) { | |||
}) | |||
} | |||
|
|||
createInOperator <- function(op) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually we don't need the createInOperator
function -- You can just add the setMethod
below after cast
etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. I will modify soon. Thanks.
Test build #35488 has finished for PR 6941 at commit
|
Test build #35490 has finished for PR 6941 at commit
|
@shivaram I modified the position of |
@@ -210,6 +210,18 @@ setMethod("cast", | |||
} | |||
}) | |||
|
|||
#' Specify multiple values |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you write a slightly more detailed description of what this operator does ? It will be great to also have a short example (similar to what we have for cast
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure!
Test build #35517 has finished for PR 6941 at commit
|
Merged build finished. Test FAILed. |
LGTM, merged into master, thanks! |
@davies Thank you for merging it! |
[SPARK-8431] Add in operator to DataFrame Column in SparkR - ASF JIRA