[SPARK-8393] [Streaming] Handle InterruptedException on awaitTermination variants #6969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pulling functionality from apache spark
pull latest from apache spark
Pulling functionality from apache spark
|
Can one of the admins verify this patch? |
| } catch { | ||
| case e: InterruptedException => | ||
| logger.info("StreamingContext interrupted at awaitTerminationOrTimeout") | ||
| false |
There was a problem hiding this comment.
You can't return false in this case, and I also don't think there is value in also logging any exception here. Refer to the JIRA for the intended change here, which was just a documentation update. You might close this PR and just open a new one.
|
@rekhajoshm can you address the comments? In particular, I think the proposal is just to fix the documentation for now. I would recommend that we close this PR and open a new one if needed.. |
|
ack @andrewor14 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle InterruptedException on awaitTermination variants