Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SQL][DOCS] Remove wrong example from DataFrame.scala #6977

Closed
wants to merge 1 commit into from

Conversation

sarutak
Copy link
Member

@sarutak sarutak commented Jun 24, 2015

In DataFrame.scala, there are examples like as follows.

 * // The following are equivalent:
 * peopleDf.filter($"age" > 15)
 * peopleDf.where($"age" > 15)
 * peopleDf($"age" > 15)

But, I think the last example doesn't work.

@SparkQA
Copy link

SparkQA commented Jun 24, 2015

Test build #35658 has finished for PR 6977 at commit 46efbd7.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@sarutak sarutak changed the title [SQL][DOCS] Removed wrong example [SQL][DOCS] Remove wrong example from DataFrame.scala Jun 24, 2015
@JoshRosen
Copy link
Contributor

@rxin, was this example intended to work?

@rxin
Copy link
Contributor

rxin commented Jun 29, 2015

Yea it used to work but we removed that from Scala API. It is still in Python for Pandas compatibility.

This commit is good.

@rxin
Copy link
Contributor

rxin commented Jun 29, 2015

I've merged this.

asfgit pushed a commit that referenced this pull request Jun 29, 2015
In DataFrame.scala, there are examples like as follows.

```
 * // The following are equivalent:
 * peopleDf.filter($"age" > 15)
 * peopleDf.where($"age" > 15)
 * peopleDf($"age" > 15)
```

But, I think the last example doesn't work.

Author: Kousuke Saruta <sarutak@oss.nttdata.co.jp>

Closes #6977 from sarutak/fix-dataframe-example and squashes the following commits:

46efbd7 [Kousuke Saruta] Removed wrong example

(cherry picked from commit 94e040d)
Signed-off-by: Reynold Xin <rxin@databricks.com>
@asfgit asfgit closed this in 94e040d Jun 29, 2015
@sarutak sarutak deleted the fix-dataframe-example branch April 12, 2016 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants