[SPARK-8611] [WebUI] Fix wrong REST UI Protocol on standalone cluster Web UI Page #7006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OK to test |
|
That looks like it could be right but can you confirm @andrewor14 ? this was added in 1390e56 |
|
Hi Sean What is the proper way to confirm with @andrewor14 ? By email? |
|
No an @ mention is fine. |
|
Hi, is there anyone who can confirm this patch? @andrewor14 or someone else |
|
Hi sorry for slipping I'll look at this today. |
| @@ -107,4 +107,8 @@ private[spark] class WorkerInfo( | |||
| def setState(state: WorkerState.Value): Unit = { | |||
| this.state = state | |||
| } | |||
|
|
|||
| def isAlive(): Boolean={ | |||
There was a problem hiding this comment.
please add spaces before and after the =
|
@thegiive two things:
Internally this uses REST / HTTP to submit it, but the external interface should use the I believe this fix here is incorrect. Would you mind closing this patch? |
|
OK. It looks wired in first. But your comment looks reasonable. BTW, I found this PR is close already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just easily change the "spark://" to "http://"