[SPARK-8650][SQL] Use the user-specified app name priority in SparkSQLCLIDriver or HiveThriftServer2 #7030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test this please. |
|
Can we query the app name in cli or beeline? If so, I am wondering if we can have a test for this change. |
|
Test build #35902 has finished for PR 7030 at commit
|
| @@ -38,9 +38,11 @@ private[hive] object SparkSQLEnv extends Logging { | |||
| val sparkConf = new SparkConf(loadDefaults = true) | |||
| val maybeSerializer = sparkConf.getOption("spark.serializer") | |||
| val maybeKryoReferenceTracking = sparkConf.getOption("spark.kryo.referenceTracking") | |||
| val maybeAppName = sparkConf.getOption("spark.app.name") | |||
| .filter(!_.equals("org.apache.spark.sql.hive.thriftserver.SparkSQLCLIDriver")) | |||
There was a problem hiding this comment.
Can you add a comment to explain this filter?
There was a problem hiding this comment.
Minor styling suggestion:
val maybeAppName = sparkConf
.getOption("spark.app.name")
.filterNot(_ == classOf[SparkSQLCLIDriver].getName)
|
LGTM |
|
ok to test |
|
Test build #36088 has finished for PR 7030 at commit
|
|
Thanks! Merging to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When run
./bin/spark-sql --name query1.sql[Before]
[After]
