[SPARK-8355] [SQL] Python DataFrameReader/Writer should mirror Scala #7078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
Jenkins, add to whitelist. |
|
Jenkins, ok to test. |
| @@ -74,6 +74,13 @@ def schema(self, schema): | |||
| return self | |||
|
|
|||
| @since(1.4) | |||
There was a problem hiding this comment.
Thanks for reviewing. Fixed.
|
Merged build triggered. |
|
Merged build started. |
|
Test build #35966 has started for PR 7078 at commit |
|
Merged build triggered. |
|
Merged build started. |
|
Test build #35968 has started for PR 7078 at commit |
|
lgtm. |
|
Test build #35966 has finished for PR 7078 at commit
|
|
Merged build finished. Test FAILed. |
|
@JoshRosen maybe a bug in the reporting script? it fails because it cannot find unit-tests.log |
|
Going to merge this. Thanks! |
|
Test build #35968 has finished for PR 7078 at commit
|
|
Merged build finished. Test FAILed. |
asfgit
pushed a commit
that referenced
this pull request
Jun 29, 2015
I compared PySpark DataFrameReader/Writer against Scala ones. `Option` function is missing in both reader and writer, but the rest seems to all match. I added `Option` to reader and writer and updated the `pyspark-sql` test. Author: Cheolsoo Park <cheolsoop@netflix.com> Closes #7078 from piaozhexiu/SPARK-8355 and squashes the following commits: c63d419 [Cheolsoo Park] Fix version 524e0aa [Cheolsoo Park] Add option function to df reader and writer (cherry picked from commit ac2e17b) Signed-off-by: Reynold Xin <rxin@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I compared PySpark DataFrameReader/Writer against Scala ones.
Optionfunction is missing in both reader and writer, but the rest seems to all match.I added
Optionto reader and writer and updated thepyspark-sqltest.