[SPARK-8710] [SQL] Change ScalaReflection.mirror from a val to a def. #7094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merged build triggered. |
|
Merged build started. |
|
Merged build finished. Test FAILed. |
| @@ -28,7 +28,8 @@ import org.apache.spark.sql.types._ | |||
| */ | |||
| object ScalaReflection extends ScalaReflection { | |||
| val universe: scala.reflect.runtime.universe.type = scala.reflect.runtime.universe | |||
| val mirror: universe.Mirror = universe.runtimeMirror(Thread.currentThread().getContextClassLoader) | |||
| override def mirror: universe.Mirror = | |||
There was a problem hiding this comment.
can you add inline comment explaining why this needs to be a def?
|
Merged build triggered. |
|
Merged build started. |
|
Test build #36037 has started for PR 7094 at commit |
|
lgtm |
|
Test build #36037 has finished for PR 7094 at commit
|
|
Merged build finished. Test PASSed. |
|
Merged. |
asfgit
pushed a commit
that referenced
this pull request
Jun 29, 2015
jira: https://issues.apache.org/jira/browse/SPARK-8710 Author: Yin Huai <yhuai@databricks.com> Closes #7094 from yhuai/SPARK-8710 and squashes the following commits: c854baa [Yin Huai] Change ScalaReflection.mirror from a val to a def. (cherry picked from commit 4b497a7) Signed-off-by: Reynold Xin <rxin@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jira: https://issues.apache.org/jira/browse/SPARK-8710