Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-1841]: update scalatest to version 2.1.5 #713

Closed
wants to merge 13 commits into from
Closed

[SPARK-1841]: update scalatest to version 2.1.5 #713

wants to merge 13 commits into from

Conversation

witgo
Copy link
Contributor

@witgo witgo commented May 9, 2014

No description provided.

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@witgo witgo changed the title [WIP] update scalatest to version 2.1.5 [WIP] [SPARK-1841]: update scalatest to version 2.1.5 May 15, 2014
@witgo witgo mentioned this pull request May 16, 2014
Closed
@pwendell
Copy link
Contributor

Jenkins, test this please (I think there are some code style issues here).

@AmplabJenkins
Copy link

Build triggered.

@AmplabJenkins
Copy link

Build started.

@AmplabJenkins
Copy link

Build finished.

@AmplabJenkins
Copy link

Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15043/

@witgo
Copy link
Contributor Author

witgo commented May 16, 2014

@pwendell
Code style issues has been fixed

@witgo witgo changed the title [WIP] [SPARK-1841]: update scalatest to version 2.1.5 [SPARK-1841]: update scalatest to version 2.1.5 May 23, 2014
@ktham
Copy link

ktham commented Jun 4, 2014

Can we get this merged soon?

@pwendell
Copy link
Contributor

pwendell commented Jun 4, 2014

@ktham hey could you explain what features you are interest in? The dependency graph of Spark is pretty complicated so we try to defend any updates by at least having an idea of what new features they are providing. This patch and associated JIRA don't mention any specific features.

@ktham
Copy link

ktham commented Jun 4, 2014

@pwendell that is of course a fair stance which I understand.

Regarding the scalatest library, there were a lot of changes in the 2.x release, but most of the existing 1.x tests should still run with scalatest 2.1.5. In particular, what's noteworthy mainly that I would like to see this in is that they have a build for Scala 2.11. The rationale being that we will eventually want to cross compile with Scala 2.11, which means its inevitable that we will in anyways be required to raise this dependency version so long as we wish to use scalatest as our testing framework. That's an unfortunate drawback when depending on a scala library, that we must also depend on when they build for a particular Scala version :-(

So long as the test suite all passes, is there any reason why we would not want to bump scalatest up?

@rxin
Copy link
Contributor

rxin commented Jun 6, 2014

Jenkins, add to whitelist.

@AmplabJenkins
Copy link

Build triggered.

@AmplabJenkins
Copy link

Merged build triggered.

@AmplabJenkins
Copy link

Build started.

@AmplabJenkins
Copy link

Build finished. All automated tests passed.

@AmplabJenkins
Copy link

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15503/

@AmplabJenkins
Copy link

Merged build started.

@AmplabJenkins
Copy link

Merged build finished. All automated tests passed.

@AmplabJenkins
Copy link

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15505/

@pwendell
Copy link
Contributor

pwendell commented Jun 6, 2014

Okay great - those are good reasons, I just wanted to have some documentation somewhere of the motivation for this change. I can merge this, thanks.

@asfgit asfgit closed this in 41c4a33 Jun 6, 2014
markhamstra pushed a commit to markhamstra/spark that referenced this pull request Jun 7, 2014
@witgo @markhamstra
[SPARK-1841]: update scalatest to version 2.1.5
056deef 
Author: witgo <witgo@qq.com>

Closes apache#713 from witgo/scalatest and squashes the following commits:

b627a6a [witgo] merge master
51fb3d6 [witgo] merge master
3771474 [witgo] fix RDDSuite
996d6f9 [witgo] fix TimeStampedWeakValueHashMap test
9dfa4e7 [witgo] merge bug
1479b22 [witgo] merge master
29b9194 [witgo] fix code style
022a7a2 [witgo] fix test dependency
a52c0fa [witgo] fix test dependency
cd8f59d [witgo] Merge branch 'master' of https://github.com/apache/spark into scalatest
046540d [witgo] fix RDDSuite.scala
2c543b9 [witgo] fix ReplSuite.scala
c458928 [witgo] update scalatest to version 2.1.5

Conflicts:
	core/pom.xml
	core/src/test/scala/org/apache/spark/ContextCleanerSuite.scala
	core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala
	core/src/test/scala/org/apache/spark/util/TimeStampedHashMapSuite.scala
	pom.xml
	project/SparkBuild.scala
	sql/core/src/test/scala/org/apache/spark/sql/parquet/ParquetQuerySuite.scala
@witgo witgo deleted the scalatest branch June 7, 2014 01:08
markhamstra pushed a commit to markhamstra/spark that referenced this pull request Jun 13, 2014
@witgo @markhamstra
[SPARK-1841]: update scalatest to version 2.1.5
2b77e24 
Author: witgo <witgo@qq.com>

Closes apache#713 from witgo/scalatest and squashes the following commits:

b627a6a [witgo] merge master
51fb3d6 [witgo] merge master
3771474 [witgo] fix RDDSuite
996d6f9 [witgo] fix TimeStampedWeakValueHashMap test
9dfa4e7 [witgo] merge bug
1479b22 [witgo] merge master
29b9194 [witgo] fix code style
022a7a2 [witgo] fix test dependency
a52c0fa [witgo] fix test dependency
cd8f59d [witgo] Merge branch 'master' of https://github.com/apache/spark into scalatest
046540d [witgo] fix RDDSuite.scala
2c543b9 [witgo] fix ReplSuite.scala
c458928 [witgo] update scalatest to version 2.1.5

Conflicts:
	core/pom.xml
	core/src/test/scala/org/apache/spark/ContextCleanerSuite.scala
	core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala
	core/src/test/scala/org/apache/spark/util/TimeStampedHashMapSuite.scala
	pom.xml
	project/SparkBuild.scala
	sql/core/src/test/scala/org/apache/spark/sql/parquet/ParquetQuerySuite.scala
marmbrus pushed a commit to marmbrus/spark that referenced this pull request Jun 13, 2014
@witgo @marmbrus
[SPARK-1841]: update scalatest to version 2.1.5
22be674 
Author: witgo <witgo@qq.com>

Closes apache#713 from witgo/scalatest and squashes the following commits:

b627a6a [witgo] merge master
51fb3d6 [witgo] merge master
3771474 [witgo] fix RDDSuite
996d6f9 [witgo] fix TimeStampedWeakValueHashMap test
9dfa4e7 [witgo] merge bug
1479b22 [witgo] merge master
29b9194 [witgo] fix code style
022a7a2 [witgo] fix test dependency
a52c0fa [witgo] fix test dependency
cd8f59d [witgo] Merge branch 'master' of https://github.com/apache/spark into scalatest
046540d [witgo] fix RDDSuite.scala
2c543b9 [witgo] fix ReplSuite.scala
c458928 [witgo] update scalatest to version 2.1.5
@witgo witgo mentioned this pull request Jun 25, 2014
Closed
pdeyhim pushed a commit to pdeyhim/spark-1 that referenced this pull request Jun 25, 2014
@witgo @pdeyhim
[SPARK-1841]: update scalatest to version 2.1.5
a761f16 
Author: witgo <witgo@qq.com>

Closes apache#713 from witgo/scalatest and squashes the following commits:

b627a6a [witgo] merge master
51fb3d6 [witgo] merge master
3771474 [witgo] fix RDDSuite
996d6f9 [witgo] fix TimeStampedWeakValueHashMap test
9dfa4e7 [witgo] merge bug
1479b22 [witgo] merge master
29b9194 [witgo] fix code style
022a7a2 [witgo] fix test dependency
a52c0fa [witgo] fix test dependency
cd8f59d [witgo] Merge branch 'master' of https://github.com/apache/spark into scalatest
046540d [witgo] fix RDDSuite.scala
2c543b9 [witgo] fix ReplSuite.scala
c458928 [witgo] update scalatest to version 2.1.5
xiliu82 pushed a commit to xiliu82/spark that referenced this pull request Sep 4, 2014
@witgo @conviva-zz
[SPARK-1841]: update scalatest to version 2.1.5
c8ad296 
Author: witgo <witgo@qq.com>

Closes apache#713 from witgo/scalatest and squashes the following commits:

b627a6a [witgo] merge master
51fb3d6 [witgo] merge master
3771474 [witgo] fix RDDSuite
996d6f9 [witgo] fix TimeStampedWeakValueHashMap test
9dfa4e7 [witgo] merge bug
1479b22 [witgo] merge master
29b9194 [witgo] fix code style
022a7a2 [witgo] fix test dependency
a52c0fa [witgo] fix test dependency
cd8f59d [witgo] Merge branch 'master' of https://github.com/apache/spark into scalatest
046540d [witgo] fix RDDSuite.scala
2c543b9 [witgo] fix ReplSuite.scala
c458928 [witgo] update scalatest to version 2.1.5
Alexis-D pushed a commit to Alexis-D/spark that referenced this pull request Nov 16, 2020
@fsamuel-bs
Add ExecutorPlugin methods called on Task Start/End (apache#713)
73ce892 
* wip

* API with docs

* move from Executor constructor to runtime

* style

* license

* style

* address comments
RolatZhang pushed a commit to RolatZhang/spark that referenced this pull request Dec 8, 2023
@yhcast0
AL-9236 Replace guava ordering with guava32 code snippet to resolve p…
d65de74 
…erformace issue (apache#712) (apache#713)
RolatZhang pushed a commit to RolatZhang/spark that referenced this pull request Dec 11, 2023
@yhcast0
AL-9236 Replace guava ordering with guava32 code snippet to resolve p…
faf3d33 
…erformace issue (apache#712) (apache#713)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@witgo @AmplabJenkins @pwendell @ktham @rxin