Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-7714][SPARKR] SparkR tests should use more specific expectations than expect_true #7152

Closed
wants to merge 4 commits into from

Conversation

sun-rui
Copy link
Contributor

@sun-rui sun-rui commented Jul 1, 2015

  1. Update the pattern 'expect_true(a == b)' to 'expect_equal(a, b)'.
  2. Update the pattern 'expect_true(inherits(a, b))' to 'expect_is(a, b)'.
  3. Update the pattern 'expect_true(identical(a, b))' to 'expect_identical(a, b)'.

@AmplabJenkins
Copy link

Merged build triggered.

@AmplabJenkins
Copy link

Merged build started.

@SparkQA
Copy link

SparkQA commented Jul 1, 2015

Test build #36238 has started for PR 7152 at commit 8fe9f0c.

@SparkQA
Copy link

SparkQA commented Jul 1, 2015

Test build #36238 has finished for PR 7152 at commit 8fe9f0c.

  • This patch fails SparkR unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Merged build finished. Test FAILed.

@AmplabJenkins
Copy link

Merged build triggered.

@AmplabJenkins
Copy link

Merged build started.

@SparkQA
Copy link

SparkQA commented Jul 1, 2015

Test build #36251 has started for PR 7152 at commit 8ad2440.

@SparkQA
Copy link

SparkQA commented Jul 1, 2015

Test build #36251 has finished for PR 7152 at commit 8ad2440.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Merged build finished. Test PASSed.

@shivaram
Copy link
Contributor

shivaram commented Jul 1, 2015

LGTM. Thanks @sun-rui for this change !

@asfgit asfgit closed this in 69c5dee Jul 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants