Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-8766] support non-ascii character in column names #7165

Closed
wants to merge 3 commits into from

Conversation

davies
Copy link
Contributor

@davies davies commented Jul 1, 2015

Use UTF-8 to encode the name of column in Python 2, or it may failed to encode with default encoding ('ascii').

This PR also fix a bug when there is Java exception without error message.

@AmplabJenkins
Copy link

Merged build triggered.

@AmplabJenkins
Copy link

Merged build started.

@SparkQA
Copy link

SparkQA commented Jul 1, 2015

Test build #36299 has started for PR 7165 at commit 867754a.

@SparkQA
Copy link

SparkQA commented Jul 1, 2015

Test build #36299 has finished for PR 7165 at commit 867754a.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Merged build finished. Test FAILed.

@AmplabJenkins
Copy link

Merged build triggered.

@AmplabJenkins
Copy link

Merged build started.

@SparkQA
Copy link

SparkQA commented Jul 1, 2015

Test build #36306 has started for PR 7165 at commit 3b09d31.

@SparkQA
Copy link

SparkQA commented Jul 1, 2015

Test build #36306 has finished for PR 7165 at commit 3b09d31.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Merged build finished. Test FAILed.

@AmplabJenkins
Copy link

Merged build triggered.

@AmplabJenkins
Copy link

Merged build started.

@SparkQA
Copy link

SparkQA commented Jul 1, 2015

Test build #36313 has started for PR 7165 at commit 02cb61a.

@SparkQA
Copy link

SparkQA commented Jul 1, 2015

Test build #36313 has finished for PR 7165 at commit 02cb61a.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • trait ExpectsInputTypes
    • trait AutoCastInputTypes

@AmplabJenkins
Copy link

Merged build finished. Test PASSed.

@davies
Copy link
Contributor Author

davies commented Jul 1, 2015

cc @rxin

@rxin
Copy link
Contributor

rxin commented Jul 1, 2015

LGTM

@asfgit asfgit closed this in f958f27 Jul 1, 2015
asfgit pushed a commit that referenced this pull request Jul 2, 2015
Use UTF-8 to encode the name of column in Python 2, or it may failed to encode with default encoding ('ascii').

This PR also fix a bug when there is Java exception without error message.

Author: Davies Liu <davies@databricks.com>

Closes #7165 from davies/non_ascii and squashes the following commits:

02cb61a [Davies Liu] fix tests
3b09d31 [Davies Liu] add encoding in header
867754a [Davies Liu] support non-ascii character in column names

(cherry picked from commit f958f27)
Signed-off-by: Davies Liu <davies@databricks.com>

Conflicts:
	python/pyspark/sql/utils.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants