-
Notifications
You must be signed in to change notification settings - Fork 28.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-8660] [MLLib] removed > symbols from comments in LogisticRegressionSuite.scala for ease of copypaste #7167
Conversation
…ine comment in order to make copypaste into R easier, in file classification/LogisticRegressionSuite.scala
…ments to regular multiline comments to make it easier to copy-paste the R code.
Can one of the admins verify this patch? |
@mengxr Would it be desirable to un-multiline the LOC in the file's comments? Or should these remain multiline to follow style? (What I mean is, the lines are long enough that they were being broken into multiple lines, so copy-pasting them would be harder. I made them back into single-line.) |
For copypasteing in Scala mode :paste mode makes the multi-line copy/past work well (although requires remembering that + ctrl-d) |
Let's keep the line width within 100. As @holdenk mentioned, we can copy & paste a paragraph of code to Scala and ipython easily. I also tried RStudio, which takes multiline statement as well. |
…RegressionSuite.scala
ok to test |
LGTM pending Jenkins. |
Merged build triggered. |
Merged build started. |
Test build #36316 has started for PR 7167 at commit |
Test build #36316 has finished for PR 7167 at commit
|
Merged build finished. Test PASSed. |
Merged into master. Thanks! |
'>' symbols removed from comments in LogisticRegressionSuite.scala, for ease of copypaste
also single-lined the multiline commands (is this desirable, or does it violate style?)