Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-8770][SQL] Create BinaryOperator abstract class. #7170

Closed
wants to merge 1 commit into from
Closed

[SPARK-8770][SQL] Create BinaryOperator abstract class. #7170

wants to merge 1 commit into from

Commits on Jul 1, 2015

  1. [SPARK-8770][SQL] Create BinaryOperator abstract class. 

    Our current BinaryExpression abstract class is not for generic binary expressions, i.e. it requires left/right children to have the same type. However, due to its name, contributors build new binary expressions that don't have that assumption (e.g. Sha) and still extend BinaryExpression.

This patch creates a new BinaryOperator abstract class, and update the analyzer o only apply type casting rule there.

This patch also adds the notion of "prettyName" to expressions, which defines the user-facing name for the expression.

/Users/rxin/Desktop/status-match
    @rxin
    rxin committed Jul 1, 2015
    Configuration menu
    Copy the full SHA
    51264a5 View commit details
    Browse the repository at this point in the history