[SPARK-8572] [SQL] Type coercion for ScalaUDFs #7203
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #36457 has finished for PR 7203 at commit
|
| @@ -126,7 +126,8 @@ class UDFRegistration private[sql] (sqlContext: SQLContext) extends Logging { | |||
| */ | |||
| def register[RT: TypeTag](name: String, func: Function0[RT]): UserDefinedFunction = { | |||
| val dataType = ScalaReflection.schemaFor[RT].dataType | |||
| def builder(e: Seq[Expression]) = ScalaUDF(func, dataType, e) | |||
| val inputTypes = Seq[DataType]() | |||
There was a problem hiding this comment.
can you update the script earlier to include this new line?
There was a problem hiding this comment.
it's just a few lines above this
There was a problem hiding this comment.
@rxin Thank you for reviewing! I updated the script.
| @@ -87,6 +87,7 @@ class UDFRegistration private[sql] (sqlContext: SQLContext) extends Logging { | |||
| (0 to 22).map { x => | |||
| val types = (1 to x).foldRight("RT")((i, s) => {s"A$i, $s"}) | |||
| val typeTags = (1 to x).map(i => s"A${i}: TypeTag").foldLeft("RT: TypeTag")(_ + ", " + _) | |||
| val inputTypes = (1 to x).foldLeft("Nil")((s, i) => {s"$s :+ ScalaReflection.schemaFor[A$i].dataType"}) | |||
There was a problem hiding this comment.
I think the convention is usually
a :: b :: c :: Nilrather than
Nil :+ a :+ ...Do you mind updating it?
|
Looks good. Just two nitpicks. |
|
LGTM. |
|
Test build #36479 has finished for PR 7203 at commit
|
|
Test build #36486 has finished for PR 7203 at commit
|
|
lgtm |
|
Thanks. I've merged this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented type coercion for udf arguments in Scala. The changes include-
with ExpectsInputTypestoScalaUDFclass.UDFRegistrationandfunctions.With this patch, the example query in SPARK-8572 no longer throws a type cast error at runtime.
Also added a unit test to
UDFSuitein which a decimal type is passed to a udf that expects an int.