Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-8531] [ML] Update ML user guide for MinMaxScaler #7211

Closed
wants to merge 5 commits into from
Closed

[SPARK-8531] [ML] Update ML user guide for MinMaxScaler #7211

wants to merge 5 commits into from

Conversation

hhbyyh
Copy link
Contributor

@hhbyyh hhbyyh commented Jul 3, 2015

jira: https://issues.apache.org/jira/browse/SPARK-8531

Update ML user guide for MinMaxScaler

@SparkQA
Copy link

SparkQA commented Jul 3, 2015

Test build #36492 has finished for PR 7211 at commit a0725a5.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Aug 3, 2015

Test build #39525 has finished for PR 7211 at commit 40942a7.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

jkbradley
jkbradley reviewed Aug 11, 2015
View reviewed changes
docs/ml-features.md
@@ -865,6 +865,7 @@ val scaledData = scalerModel.transform(dataFrame)
{% highlight java %}
import org.apache.spark.api.java.JavaRDD;
import org.apache.spark.ml.feature.StandardScaler;
import org.apache.spark.ml.feature.StandardScalerModel;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

@jkbradley
Copy link
Member

Would you mind adding an example for Python too? Or we can make that a separate PR if you prefer.

@SparkQA
Copy link

SparkQA commented Aug 13, 2015

Test build #40741 has finished for PR 7211 at commit b6ac0fc.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@hhbyyh
Copy link
Contributor Author

hhbyyh commented Aug 13, 2015

@jkbradley Thanks for the review.
I'm not sure if the latex part looks good.
And for python document, since python interface for MinMaxScaler is still under review, so I didn't add the example.

jkbradley
jkbradley reviewed Aug 18, 2015
View reviewed changes
docs/ml-features.md
The following example demonstrates how to load a dataset in libsvm format and then rescale each feature to [0, 1].

<div class="codetabs">
<div data-lang="scala">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The links are not generated correctly, but you can fix it by modifying this line:

<div data-lang="scala" markdown="1">

@jkbradley
Copy link
Member

The latex part looks much better now.

@jkbradley
Copy link
Member

ping!

@hhbyyh
Copy link
Contributor Author

hhbyyh commented Aug 24, 2015

Sorry for the delay. I am in my hometown and has poor internet connection. I'll be back to office tomorrow and start catching up.

@SparkQA
Copy link

SparkQA commented Aug 24, 2015

Test build #41489 has finished for PR 7211 at commit 1622f85.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@jkbradley
Copy link
Member

Thank you for updating it. LGTM.
Merging with master and branch-1.5

asfgit pushed a commit that referenced this pull request Aug 25, 2015
@hhbyyh @jkbradley
[SPARK-8531] [ML] Update ML user guide for MinMaxScaler
742c82e 
jira: https://issues.apache.org/jira/browse/SPARK-8531

Update ML user guide for MinMaxScaler

Author: Yuhao Yang <hhbyyh@gmail.com>
Author: unknown <yuhaoyan@yuhaoyan-MOBL1.ccr.corp.intel.com>

Closes #7211 from hhbyyh/minmaxdoc.

(cherry picked from commit b37f0cc)
Signed-off-by: Joseph K. Bradley <joseph@databricks.com>
@asfgit asfgit closed this in b37f0cc Aug 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@hhbyyh @SparkQA @jkbradley