Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-8841] [SQL] Fix partition pruning percentage log message #7227

Closed
wants to merge 1 commit into from

Conversation

srlindemann
Copy link

When pruning partitions for a query plan, a message is logged indicating what how many partitions were selected based on predicate criteria, and what percent were pruned.

The current release erroneously uses 1 - total/selected to compute this quantity, leading to nonsense messages like "pruned -1000% partitions". The fix is simple and obvious.

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@squito
Copy link
Contributor

squito commented Jul 5, 2015

Jenkins, ok to test

@squito
Copy link
Contributor

squito commented Jul 5, 2015

lgtm

@rxin
Copy link
Contributor

rxin commented Jul 6, 2015

Jenkins, test this please.

(Did something go wrong with Jenkins?)

@rxin
Copy link
Contributor

rxin commented Jul 6, 2015

cc @liancheng

@liancheng
Copy link
Contributor

ok to test

@AmplabJenkins
Copy link

Merged build triggered.

@liancheng
Copy link
Contributor

@srlindemann Thanks for fixing this! Could you please file a JIRA and change the PR title to "[SPARK-xxxx] [SQL] Fix partition pruning percentage log message"?

@srowen
Copy link
Member

srowen commented Jul 6, 2015

Is this even worth a JIRA? there is virtually no difference between the description and fix

@AmplabJenkins
Copy link

Merged build started.

@SparkQA
Copy link

SparkQA commented Jul 6, 2015

Test build #36567 has started for PR 7227 at commit c788061.

@SparkQA
Copy link

SparkQA commented Jul 6, 2015

Test build #36567 has finished for PR 7227 at commit c788061.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Merged build finished. Test PASSed.

@srlindemann
Copy link
Author

I saw on one of the contrib pages that trivial changes might not have a
JIRA, so I skipped it here. Happy to do it though if you like.
On Jul 6, 2015 4:38 AM, "Sean Owen" notifications@github.com wrote:

Is this even worth a JIRA? there is virtually no difference between the
description and fix


Reply to this email directly or view it on GitHub
#7227 (comment).

@srlindemann srlindemann changed the title fix percentPruned log message [SPARK-8841] [SQL] Fix partition pruning percentage log message Jul 6, 2015
@liancheng
Copy link
Contributor

@srowen Hm, yeah, now I'd agree that this might not worth a JIRA. Anyway, filing one to track it does no harm :)

@srlindemann Thanks! Merging to master.

@asfgit asfgit closed this in 39e4e7e Jul 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
8 participants