[SPARK-8831][SQL] Support AbstractDataType in TypeCollection. #7232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -708,8 +708,6 @@ object HiveTypeCoercion { | |||
| case (NullType, target) => Cast(e, target.defaultConcreteType) | |||
|
|
|||
| // Implicit cast among numeric types | |||
| // If input is decimal, and we expect a decimal type, just use the input. | |||
| case (_: DecimalType, DecimalType) => e | |||
|
cc @YijieSHEN I think you were looking for this in round? |
|
Yep, just what I need :) |
|
LGTM |
|
Tried this out locally and works fine. LGTM as well. |
|
Test build #36558 has finished for PR 7232 at commit
|
|
Thanks for looking at this. Going to merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise it is impossible to declare an expression supporting DecimalType.