Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-8908] [SQL] Add () to distinct definition in dataframe #7298

Closed
wants to merge 1 commit into from
Closed

[SPARK-8908] [SQL] Add () to distinct definition in dataframe #7298

wants to merge 1 commit into from

Conversation

piaozhexiu
Copy link

Adding () to the definition of distinct in DataFrame allows distinct to be called with parentheses, which is consistent with dropDuplicates.

@AmplabJenkins
Copy link

Merged build triggered.

@AmplabJenkins
Copy link

Merged build started.

@SparkQA
Copy link

SparkQA commented Jul 8, 2015

Test build #36830 has started for PR 7298 at commit 7f0d923.

@sarutak
Copy link
Member

sarutak commented Jul 8, 2015

Should we change the definition of distinct in RDDApi?

@sarutak
Copy link
Member

sarutak commented Jul 8, 2015

/cc @marmbrus

@rxin
Copy link
Contributor

rxin commented Jul 8, 2015

We should just remove RDDApi ....

@SparkQA
Copy link

SparkQA commented Jul 8, 2015

Test build #36830 has finished for PR 7298 at commit 7f0d923.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Merged build finished. Test PASSed.

@rxin
Copy link
Contributor

rxin commented Jul 8, 2015

Thanks - merging this.

@asfgit asfgit closed this in 00b265f Jul 8, 2015
@sarutak sarutak mentioned this pull request Jul 8, 2015
Closed
asfgit pushed a commit that referenced this pull request Jul 9, 2015
@sarutak @rxin
[SPARK-8914][SQL] Remove RDDApi
2a4f88b 
As rxin suggested in #7298 , we should consider to remove `RDDApi`.

Author: Kousuke Saruta <sarutak@oss.nttdata.co.jp>

Closes #7302 from sarutak/remove-rddapi and squashes the following commits:

e495d35 [Kousuke Saruta] Fixed mima
cb7ebb9 [Kousuke Saruta] Removed overriding RDDApi
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@piaozhexiu @AmplabJenkins @SparkQA @sarutak @rxin