Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-8959] [SQL] [HOTFIX] Removes parquet-thrift and libthrift dependencies #7330

Closed
wants to merge 1 commit into from

Conversation

liancheng
Copy link
Contributor

These two dependencies were introduced in #7231 to help testing Parquet compatibility with parquet-thrift. However, they somehow crash the Scala compiler in Maven builds.

This PR fixes this issue by:

  1. Removing these two dependencies, and
  2. Instead of generating the testing Parquet file programmatically, checking in an actual testing Parquet file generated by parquet-thrift as a test resource.

This is just a quick fix to bring back Maven builds. Need to figure out the root case as binary Parquet files are harder to maintain.

@SparkQA
Copy link

SparkQA commented Jul 9, 2015

Test build #36960 has finished for PR 7330 at commit 2492f0c.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jul 9, 2015

Test build #36972 has finished for PR 7330 at commit cf69512.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@liancheng
Copy link
Contributor Author

Merging to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants