[SPARK-9031] Merge BlockObjectWriter and DiskBlockObject writer to remove abstract class #7391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @rxin |
|
Test build #37209 has finished for PR 7391 at commit
|
| @@ -26,55 +26,15 @@ import org.apache.spark.executor.ShuffleWriteMetrics | |||
| import org.apache.spark.util.Utils | |||
|
|
|||
| /** | |||
| * An interface for writing JVM objects to some underlying storage. This interface allows | |||
| * An interface for writing JVM objects directly to a file on disk. This interface allows | |||
|
LGTM (although compilation is broken) |
|
Test build #37234 has finished for PR 7391 at commit
|
|
Thanks - merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BlockObjectWriter has only one concrete non-test class, DiskBlockObjectWriter. In order to simplify the code in preparation for other refactorings, I think that we should remove this base class and have only DiskBlockObjectWriter.
While at one time we may have planned to have multiple BlockObjectWriter implementations, that doesn't seem to have happened, so the extra abstraction seems unnecessary.