Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-8199][SQL] follow up; revert change in test #7505

Closed
wants to merge 3 commits into from
Closed

[SPARK-8199][SQL] follow up; revert change in test #7505

wants to merge 3 commits into from

Conversation

tarekbecker
Copy link
Contributor

@rxin / @davies

Sorry for that unnecessary change. And thanks again for all your support!

@davies
Copy link
Contributor

davies commented Jul 19, 2015

@tarekauel If Calendar is created inside for-loop (i), we should use i, otherwise use 1, is it correct?

@davies
Copy link
Contributor

davies commented Jul 19, 2015

there are four more places (below that) need to be fixed.

@davies
Copy link
Contributor

davies commented Jul 19, 2015

After this rush, you should have more rest, also me. :)

@tarekbecker
Copy link
Contributor Author

Now it's right, isn't it?

@davies
Copy link
Contributor

davies commented Jul 19, 2015

LGTM.

@SparkQA
Copy link

SparkQA commented Jul 19, 2015

Test build #1113 has finished for PR 7505 at commit d09321c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@rxin
Copy link
Contributor

rxin commented Jul 19, 2015

Thanks - I've merged this.

@asfgit asfgit closed this in a53d13f Jul 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@tarekbecker @davies @SparkQA @rxin