[SPARK-9165][SQL] codegen for CreateArray, CreateStruct and CreateNamedStruct #7537
+76
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yjshen
force-pushed
the
array_struct_codegen
branch
from
3191341
to
39cefb8
Compare
|
/cc @rxin |
|
Test build #1133 has finished for PR 7537 at commit
|
| val strSeq = intSeq.map(_.toString) | ||
| checkEvaluation(CreateArray(intSeq.map(Literal(_))), intSeq, EmptyRow) | ||
| checkEvaluation(CreateArray(longSeq.map(Literal(_))), longSeq, EmptyRow) | ||
| checkEvaluation(CreateArray(strSeq.map(Literal(_))), strSeq, EmptyRow) |
There was a problem hiding this comment.
Maybe add a test that includes null values?
|
Thanks @marmbrus , I would update my code soon. |
yjshen
force-pushed
the
array_struct_codegen
branch
from
695ed31
to
5e90f0a
Compare
|
Test build #1142 has finished for PR 7537 at commit
|
| val strWithNull = strSeq.map(Literal(_)).+:(Literal.create(null, StringType)) | ||
| checkEvaluation(CreateArray(intWithNull), intSeq.+:(null), EmptyRow) | ||
| checkEvaluation(CreateArray(longWithNull), longSeq.+:(null), EmptyRow) | ||
| checkEvaluation(CreateArray(strWithNull), strSeq.+:(null), EmptyRow) |
There was a problem hiding this comment.
Sorry to nit-pick, but what is happening here is kind of confusing:
scala> List(1,2).+:(null)
res0: List[Any] = List(null, 1, 2)Perhaps just use infix notation for operators:
scala> List(1,2) :+ null
res1: List[Any] = List(1, 2, null)
|
Thanks! Merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://issues.apache.org/jira/browse/SPARK-9165