[SPARK-9121][SparkR] Get rid of the warnings about no visible global function definition in SparkR
#7567
Conversation
… function definition` in SparkR
|
Test build #37939 has finished for PR 7567 at commit
|
| expect_equal(actual$name(), expectedName) | ||
| expect_equal(actual$dataType.toString(), expectedType) | ||
| expect_equal(actual$nullable(), expectedNullable) | ||
| testthat::expect_equal(class(actual), "structField") |
There was a problem hiding this comment.
We don't need to do this -- instead we can include library(testthat) in our lint-R script as Jenkins and developers who run unit tests should have this package installed.
There was a problem hiding this comment.
Alright. I will modify it soon. Thank you for the comment.
…ull path of function.
| # NOTE: You should install SparkR with `R/install-dev.sh` before running this script. | ||
| library(lintr) | ||
| library(testthat) | ||
| library(SparkR, lib.loc = file.path(SPARK_ROOT_DIR, "R", "lib")) |
There was a problem hiding this comment.
Minor thing -- it would be good for the script to exit if any of these package loads fail. We can pass in logical.return=T to the library call to do this.
There was a problem hiding this comment.
Sure. I have added the validation.
|
Test build #38002 has finished for PR 7567 at commit
|
|
Jenkins, test this please. |
| library(methods) | ||
| library(testthat) | ||
| if (! library(SparkR, lib.loc = file.path(SPARK_ROOT_DIR, "R", "lib"), logical.return = TRUE)) { | ||
| stop("You should install SparkR in a local directory with `R/instlal-dev.sh`.") |
There was a problem hiding this comment.
Minor typo here -- It should be install-dev.sh
|
Test build #37997 has finished for PR 7567 at commit
|
|
LGTM. Thanks @yu-iskw |
|
Test build #46 has finished for PR 7567 at commit
|
|
Jenkins, retest this please |
|
Test build #38003 has finished for PR 7567 at commit
|
|
Test build #38009 timed out for PR 7567 at commit |
|
Test build #38020 has finished for PR 7567 at commit
|
|
Finally the tests passed ! Merging this. |
|
@shivaram Thank you for reviewing it and merging it! |
[SPARK-9121] Get rid of the warnings about
no visible global function definitionin SparkR - ASF JIRAThe Result of
dev/lint-rThe result of lint-r for SPARK-9121 at the revision:1ddd0f2f1688560f88470e312b72af04364e2d49 when I have sent a PR