[SPARK-9352] [SPARK-9353] [HOTFIX] Reverts PR #7668 on branch-1.4 #7686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @andrewor14 |
|
I'm merging this to branch-1.4 to bring Jenkins 1.4 builders back. |
liancheng
changed the title
asfgit
pushed a commit
that referenced
this pull request
Jul 27, 2015
`MasterSuite.makeMaster()` doesn't compile under 1.4. `Master` is still an actor in branch-1.4, and can only be created via `ActorSystem.actorOf`, or with `TestActorRef`. Author: Cheng Lian <lian@databricks.com> Closes #7686 from liancheng/hotfix-revert-pr-7668 and squashes the following commits: 089a1a8 [Cheng Lian] Revert "[SPARK-9352] [SPARK-9353] Add tests for standalone scheduling code" 54e8ab0 [Cheng Lian] Revert "[HOTFIX] Fix compile in MasterSuite"
|
Thanks @liancheng for fixing this. I'll do a more careful job back porting next time. |
|
(could you close this since it's already merged?) |
|
Test build #38510 has finished for PR 7686 at commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MasterSuite.makeMaster()doesn't compile under 1.4.Masteris still an actor in branch-1.4, and can only be created viaActorSystem.actorOf, or withTestActorRef.