-
Notifications
You must be signed in to change notification settings - Fork 28.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-3181][MLLIB]: Add Robust Regression Algorithm with Huber Estimator #7722
Conversation
Test build #38683 has finished for PR 7722 at commit
|
Test build #38787 has finished for PR 7722 at commit
|
Test build #38829 has finished for PR 7722 at commit
|
Test build #38827 has finished for PR 7722 at commit
|
Test build #38826 has finished for PR 7722 at commit
|
Test build #38828 has finished for PR 7722 at commit
|
Hm... I suppose I would expect to optionally change the cost function to something like absolute error, rather than introduce a different class. this is still essentially linear regression right? If the difference is more than the cost function, I could see making a parallel implementation, but that seems like a lot of duplication to avoid if possible. |
Discussed with @dbtsai offline. He suggested using |
I will have them in the same |
* It's used in Breeze's convex optimization routines. | ||
*/ | ||
private class HuberCostFun( | ||
data: RDD[(Double, Vector)], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indentation
We also need the unit-tests. |
Test build #39626 has finished for PR 7722 at commit
|
Please add the unit tests. Thanks. |
Test build #39782 has finished for PR 7722 at commit
|
Test build #39786 has finished for PR 7722 at commit
|
@AmplabJenkins I can build. Can you re-test please? |
Test build #39793 has finished for PR 7722 at commit
|
@AmplabJenkins Need your help. I can build with this command: and I can run all the tests. Please help understand the errors: |
Test build #39949 has finished for PR 7722 at commit
|
Huber Robust Regression under spark/ml/regression