Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-9420][SQL] Move expressions in sql/core package to catalyst. #7735

Closed
wants to merge 1 commit into from

Conversation

rxin
Copy link
Contributor

@rxin rxin commented Jul 28, 2015

Since catalyst package already depends on Spark core, we can move those expressions
into catalyst, and simplify function registry.

This is a followup of #7478.

Since catalyst package already depends on Spark core, we can move those expressions
into catalyst, and simplify function registry.
@marmbrus
Copy link
Contributor

LGTM

@rxin
Copy link
Contributor Author

rxin commented Jul 28, 2015

I also renamed spark__partition__id to spark_partition_id.

cc @JDrit

@JDrit
Copy link
Contributor

JDrit commented Jul 28, 2015

The other function in the umbrella ticket was for input_file_name() in which @rxin has suggested to use a thread local variable in SqlNewHadoopRDD. That function could not be put in FunctionRegistry since it would need access to the SQL package right?

@rxin
Copy link
Contributor Author

rxin commented Jul 28, 2015

We can add the thread local variable in sql/core, and the expression itself in sql/catalyst? There is no build dependency for looking up thread local variables.

@SparkQA
Copy link

SparkQA commented Jul 28, 2015

Test build #38770 has finished for PR 7735 at commit 2ffbdc3.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@asfgit asfgit closed this in b7f5411 Jul 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants