[SPARK-9400][SQL] codeGen stringLocate #7779
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins, ok to test. |
|
Test build #1251 has finished for PR 7779 at commit
|
| int ${ev.primitive} = 0; | ||
| boolean ${ev.isNull} = false; | ||
| ${startGen.code} | ||
| if (!${startGen.isNull}) { |
There was a problem hiding this comment.
@tarekauel can we specialize code gen for cases where str / start is foldable?
Once you do that, make sure you update the test cases to use NonFoldableLiteral (just search the code base for how it is used).
There was a problem hiding this comment.
I think we do not need the special case here, because we can directly call UTF8String.indexOf()
|
LGTM, will merge this into master (fixing the confict). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://issues.apache.org/jira/browse/SPARK-9400