[SPARK-6684] [mllib] [ml] Add checkpointing to GBTs #7804
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -144,6 +144,7 @@ final class EMLDAOptimizer extends LDAOptimizer { | |||
| this.checkpointInterval = lda.getCheckpointInterval | |||
| this.graphCheckpointer = new PeriodicGraphCheckpointer[TopicCounts, TokenCount]( | |||
| checkpointInterval, graph.vertices.sparkContext) | |||
| this.graphCheckpointer.update(this.graph) | |||
There was a problem hiding this comment.
This should have been done in the previous PR.
| @@ -269,6 +269,8 @@ object GradientBoostedTrees extends Logging { | |||
| logInfo("Internal timing for DecisionTree:") | |||
| logInfo(s"$timer") | |||
|
|
|||
| predErrorCheckpointer.deleteAllCheckpoints() | |||
There was a problem hiding this comment.
Not in this PR, but what if we want to keep the last RDD checkpointed in the queue?
There was a problem hiding this comment.
It should not be a problem for recoverability (unless the driver crashes), but that sounds useful for model stats. To do!
|
LGTM except one minor comment. |
|
Test build #39097 has finished for PR 7804 at commit
|
|
Test build #39101 has finished for PR 7804 at commit
|
|
Test build #39111 has finished for PR 7804 at commit
|
|
merging with master. Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add checkpointing to GradientBoostedTrees, GBTClassifier, GBTRegressor
CC: @mengxr