Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-8936][MLlib] OnlineLDA document-topic Dirichlet hyperparameter optimization #7836

Closed

Conversation

feynmanliang
Copy link
Contributor

Adds alpha (document-topic Dirichlet parameter) hyperparameter optimization to OnlineLDAOptimizer following Huang: Maximum Likelihood Estimation of Dirichlet Distribution Parameters. Also introduces a private setSampleWithReplacement to OnlineLDAOptimizer for unit testing purposes.

@SparkQA
Copy link

SparkQA commented Jul 31, 2015

Test build #39246 has finished for PR 7836 at commit cef5b76.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jul 31, 2015

Test build #39250 has finished for PR 7836 at commit a31b084.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Feynman Liang added 2 commits July 31, 2015 12:58
(cherry picked from commit 9f67a803df765170342be0c56239b679192df32c)
@SparkQA
Copy link

SparkQA commented Jul 31, 2015

Test build #39259 has finished for PR 7836 at commit 151e859.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class MultilayerPerceptronClassifier(override val uid: String)
    • class KinesisUtils(object):
    • class InitialPositionInStream(object):

@jkbradley
Copy link
Member

LGTM pending tests

@SparkQA
Copy link

SparkQA commented Jul 31, 2015

Test build #39286 has finished for PR 7836 at commit 4bef484.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class MultilayerPerceptronClassifier(override val uid: String)
    • class KinesisUtils(object):
    • class InitialPositionInStream(object):

@jkbradley
Copy link
Member

@feynmanliang I just noticed: Can you please add the "mllib" tag to the PR title?

@feynmanliang feynmanliang changed the title [SPARK-8936] OnlineLDA document-topic Dirichlet hyperparameter optimization [SPARK-8936][MLlib] OnlineLDA document-topic Dirichlet hyperparameter optimization Aug 1, 2015
@feynmanliang
Copy link
Contributor Author

@jkbradley Sure

On Fri, Jul 31, 2015 at 5:30 PM jkbradley notifications@github.com wrote:

@feynmanliang https://github.com/feynmanliang I just noticed: Can you
please add the "mllib" tag to the PR title?


Reply to this email directly or view it on GitHub
#7836 (comment).

@asfgit asfgit closed this in f51fd6f Aug 1, 2015
@feynmanliang feynmanliang deleted the SPARK-8936-alpha-optimize branch August 3, 2015 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants