[SPARK-9546][SQL] Centralize orderable data type checking. #7880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #39473 has finished for PR 7880 at commit
|
|
Test build #39482 has finished for PR 7880 at commit
|
|
Test build #39483 has finished for PR 7880 at commit
|
| @@ -111,7 +99,7 @@ private[sql] abstract class SparkStrategies extends QueryPlanner[SparkPlan] { | |||
| // If the sort merge join option is set, we want to use sort merge join prior to hashjoin | |||
| // for now let's support inner join first, then add outer join | |||
| case ExtractEquiJoinKeys(Inner, leftKeys, rightKeys, condition, left, right) | |||
| if sqlContext.conf.sortMergeJoinEnabled && isValidSort(leftKeys, rightKeys) => | |||
| if sqlContext.conf.sortMergeJoinEnabled && RowOrdering.isOrderable(leftKeys) => | |||
There was a problem hiding this comment.
Missing && RowOrdering.isOrderable(rightKeys)?
There was a problem hiding this comment.
left/right should be the same data types -- otherwise they cannot be joined together
|
LGTM |
|
Thanks - merging this in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request creates two isOrderable functions in RowOrdering that can be used to check whether a data type or a sequence of expressions can be used in sorting.