-
Notifications
You must be signed in to change notification settings - Fork 28.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-9596][SQL]treat hadoop classes as shared one in IsolatedClientLoader #7931
Conversation
Jenkins, test this please. |
Test build #210 has finished for PR 7931 at commit
|
Test build #39712 has finished for PR 7931 at commit
|
Test build #39724 has finished for PR 7931 at commit
|
The error is:
I should not be produced by this patch. Jenkins, retest this please. |
Jenkins, retest this please. |
Test build #221 has finished for PR 7931 at commit
|
Test build #39797 has finished for PR 7931 at commit
|
Jenkins, retest this please. |
Test build #226 has finished for PR 7931 at commit
|
Test build #39837 has finished for PR 7931 at commit
|
Test build #39855 has finished for PR 7931 at commit
|
@marmbrus I am not sure why it will leads to a test failed. Could you help to check this patch and the failed reason? Thanks. |
It looks like your patch is breaking Hive. |
In particular I think that some of hives classes exist in the hadoop namespace so cannot be shared. |
Test build #39973 has finished for PR 7931 at commit
|
@marmbrus Looks like the patch is ok with excluding hive classes. Thanks for your guide :) |
Thanks, merged to master. |
@@ -124,6 +124,7 @@ private[hive] class IsolatedClientLoader( | |||
name.contains("slf4j") || | |||
name.contains("log4j") || | |||
name.startsWith("org.apache.spark.") || | |||
(name.startsWith("org.apache.hadoop.") && !name.startsWith("org.apache.hadoop.hive.")) || |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
scope is too huge, and without reload hadoop, will only have one FileSystem.Cache which will cause SPARK-11083
https://issues.apache.org/jira/browse/SPARK-9596