Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-9596][SQL]treat hadoop classes as shared one in IsolatedClientLoader #7931

Closed
wants to merge 3 commits into from

Conversation

WangTaoTheTonic
Copy link
Contributor

@WangTaoTheTonic
Copy link
Contributor Author

Jenkins, test this please.

@SparkQA
Copy link

SparkQA commented Aug 4, 2015

Test build #210 has finished for PR 7931 at commit 3abe66c.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Aug 4, 2015

Test build #39712 has finished for PR 7931 at commit 3abe66c.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Aug 4, 2015

Test build #39724 has finished for PR 7931 at commit 3abe66c.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@WangTaoTheTonic
Copy link
Contributor Author

The error is:

stderr> FAILED: SemanticException [Error 10072]: Database does not exist: hive_test_db
[info] stderr> Exception in thread "main" org.apache.spark.sql.execution.QueryExecutionException: FAILED: SemanticException [Error 10072]: Database does not exist: hive_test_db

I should not be produced by this patch.

Jenkins, retest this please.

@WangTaoTheTonic
Copy link
Contributor Author

Jenkins, retest this please.

@SparkQA
Copy link

SparkQA commented Aug 5, 2015

Test build #221 has finished for PR 7931 at commit 3abe66c.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Aug 5, 2015

Test build #39797 has finished for PR 7931 at commit 3abe66c.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@WangTaoTheTonic
Copy link
Contributor Author

Jenkins, retest this please.

@SparkQA
Copy link

SparkQA commented Aug 5, 2015

Test build #226 has finished for PR 7931 at commit 3abe66c.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Aug 5, 2015

Test build #39837 has finished for PR 7931 at commit 3abe66c.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Aug 5, 2015

Test build #39855 has finished for PR 7931 at commit cdfbe24.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@WangTaoTheTonic
Copy link
Contributor Author

@marmbrus I am not sure why it will leads to a test failed. Could you help to check this patch and the failed reason? Thanks.

@marmbrus
Copy link
Contributor

marmbrus commented Aug 5, 2015

It looks like your patch is breaking Hive.

@marmbrus
Copy link
Contributor

marmbrus commented Aug 5, 2015

In particular I think that some of hives classes exist in the hadoop namespace so cannot be shared.

@SparkQA
Copy link

SparkQA commented Aug 6, 2015

Test build #39973 has finished for PR 7931 at commit 42ea1b5.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@WangTaoTheTonic
Copy link
Contributor Author

@marmbrus Looks like the patch is ok with excluding hive classes. Thanks for your guide :)

@marmbrus
Copy link
Contributor

marmbrus commented Sep 3, 2015

Thanks, merged to master.

@asfgit asfgit closed this in 3abc0d5 Sep 3, 2015
@@ -124,6 +124,7 @@ private[hive] class IsolatedClientLoader(
name.contains("slf4j") ||
name.contains("log4j") ||
name.startsWith("org.apache.spark.") ||
(name.startsWith("org.apache.hadoop.") && !name.startsWith("org.apache.hadoop.hive.")) ||
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scope is too huge, and without reload hadoop, will only have one FileSystem.Cache which will cause SPARK-11083

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants