[SPARK-9228] [SQL] use tungsten.enabled in public for both of codegen/unsafe #7998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -223,14 +223,21 @@ private[spark] object SQLConf { | |||
| defaultValue = Some(200), | |||
| doc = "The default number of partitions to use when shuffling data for joins or aggregations.") | |||
|
|
|||
| val CODEGEN_ENABLED = booleanConf("spark.sql.codegen", | |||
| val TUNGSTEN_ENABLED = booleanConf("spark.sql.tungsten.enabled", | |||
There was a problem hiding this comment.
Should we use a better name for this? tungsten will not be easy for user to understand.
|
Test build #40055 has finished for PR 7998 at commit
|
asfgit
pushed a commit
that referenced
this pull request
Aug 7, 2015
…/unsafe spark.sql.tungsten.enabled will be the default value for both codegen and unsafe, they are kept internally for debug/testing. cc marmbrus rxin Author: Davies Liu <davies@databricks.com> Closes #7998 from davies/tungsten and squashes the following commits: c1c16da [Davies Liu] update doc 1a47be1 [Davies Liu] use tungsten.enabled for both of codegen/unsafe (cherry picked from commit 4e70e82) Signed-off-by: Davies Liu <davies.liu@gmail.com>
|
Test build #1393 has finished for PR 7998 at commit
|
|
I've merged this again. |
asfgit
pushed a commit
that referenced
this pull request
Aug 7, 2015
…/unsafe spark.sql.tungsten.enabled will be the default value for both codegen and unsafe, they are kept internally for debug/testing. cc marmbrus rxin Author: Davies Liu <davies@databricks.com> Closes #7998 from davies/tungsten and squashes the following commits: c1c16da [Davies Liu] update doc 1a47be1 [Davies Liu] use tungsten.enabled for both of codegen/unsafe (cherry picked from commit 4e70e82) Signed-off-by: Reynold Xin <rxin@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
spark.sql.tungsten.enabled will be the default value for both codegen and unsafe, they are kept internally for debug/testing.
cc @marmbrus @rxin