Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-9453] [SQL] support records larger than page size in UnsafeShuffleExternalSorter #8005

Closed
wants to merge 2 commits into from

Conversation

davies
Copy link
Contributor

@davies davies commented Aug 6, 2015

This patch follows exactly #7891 (except testing)

@SparkQA
Copy link

SparkQA commented Aug 7, 2015

Test build #40076 has finished for PR 8005 at commit 9de5c72.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

import org.apache.spark.unsafe.memory.MemoryBlock;
import org.apache.spark.unsafe.memory.TaskMemoryManager;
import org.apache.spark.util.Utils;

/**
* An external sorter that is specialized for sort-based shuffle.
* An external inMemSorter that is specialized for sort-based shuffle.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be sorter still

@rxin
Copy link
Contributor

rxin commented Aug 7, 2015

LGTM

@SparkQA
Copy link

SparkQA commented Aug 7, 2015

Test build #40138 has finished for PR 8005 at commit f9c4aff.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@rxin
Copy link
Contributor

rxin commented Aug 7, 2015

Merging in master & branch-1.5.

@asfgit asfgit closed this in 15bd6f3 Aug 7, 2015
asfgit pushed a commit that referenced this pull request Aug 7, 2015
…ffleExternalSorter

This patch follows exactly #7891 (except testing)

Author: Davies Liu <davies@databricks.com>

Closes #8005 from davies/larger_record and squashes the following commits:

f9c4aff [Davies Liu] address comments
9de5c72 [Davies Liu] support records larger than page size in UnsafeShuffleExternalSorter

(cherry picked from commit 15bd6f3)
Signed-off-by: Davies Liu <davies.liu@gmail.com>
CodingCat pushed a commit to CodingCat/spark that referenced this pull request Aug 17, 2015
…ffleExternalSorter

This patch follows exactly apache#7891 (except testing)

Author: Davies Liu <davies@databricks.com>

Closes apache#8005 from davies/larger_record and squashes the following commits:

f9c4aff [Davies Liu] address comments
9de5c72 [Davies Liu] support records larger than page size in UnsafeShuffleExternalSorter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants