[SPARK-9814][SQL] EqualNotNull not passing to data sources #8096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -38,6 +38,14 @@ case class EqualTo(attribute: String, value: Any) extends Filter | |||
|
|
|||
| /** | |||
| * A filter that evaluates to `true` iff the attribute evaluates to a value | |||
| * null safe and equal to `value`. | |||
There was a problem hiding this comment.
it'd be better if we expand this a bit to explain what null-safe means. e.g. similar to what's in mysql docs: http://dev.mysql.com/doc/refman/5.0/en/comparison-operators.html#operator%5Fequal-to
There was a problem hiding this comment.
Should I write like this?
A filter that evaluates to true if the attribute evaluates to a value equal to value and if both the attribute and the value are null.
There was a problem hiding this comment.
maybe this
Performs equality comparison, similar to [[EqualTo]]. However, this differs from [[EqualTo]] in that it returns true (rather than NULL) if both inputs are NULL, and false (rather than NULL) if one of the input is NULL and the other is not NULL.
|
Jenkins, test this please. |
|
Test build #40428 has finished for PR 8096 at commit
|
|
Reset this please :) |
|
Jenkins, retest this please. |
|
Test build #40481 has finished for PR 8096 at commit
|
|
Thanks - I've merged this. |
CodingCat
pushed a commit
to CodingCat/spark
that referenced
this pull request
Aug 17, 2015
Author: hyukjinkwon <gurwls223@gmail.com> Author: 권혁진 <gurwls223@gmail.com> Closes apache#8096 from HyukjinKwon/master.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.