Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-9772] [PySpark] [ML] Add Python API for ml.feature.VectorSlicer #8102

Closed
wants to merge 4 commits into from
Closed

[SPARK-9772] [PySpark] [ML] Add Python API for ml.feature.VectorSlicer #8102

wants to merge 4 commits into from

Conversation

yanboliang
Copy link
Contributor

Add Python API for ml.feature.VectorSlicer.

@SparkQA
Copy link

SparkQA commented Aug 11, 2015

Test build #40446 timed out for PR 8102 at commit 54bffab after a configured wait of 175m.

@yanboliang
Copy link
Contributor Author

Jenkins, test this please.

@yanboliang yanboliang changed the title [WIP] [SPARK-9772] [PySpark] [ML] Add Python API for ml.feature.VectorSlicer [SPARK-9772] [PySpark] [ML] Add Python API for ml.feature.VectorSlicer Aug 12, 2015
@jkbradley
Copy link
Member

test this please

@SparkQA
Copy link

SparkQA commented Aug 13, 2015

Test build #40826 has finished for PR 8102 at commit 54bffab.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class VectorSlicer(JavaTransformer, HasInputCol, HasOutputCol):

@jkbradley
Copy link
Member

reviewing now

jkbradley
jkbradley reviewed Aug 18, 2015
View reviewed changes
python/pyspark/ml/feature.py
... (Vectors.dense([-2.0, 2.3, 0.0, 0.0, 1.0]),),
... (Vectors.dense([0.0, 0.0, 0.0, 0.0, 0.0]),),
... (Vectors.dense([0.6, -1.1, -3.0, 4.5, 3.3]),)], ["features"])
>>> vs = VectorSlicer(inputCol="features", outputCol="expected", indices=[1, 4])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename "expected" to "sliced" since this is an example

@jkbradley
Copy link
Member

One more comment: need to add VectorSlicer to list __all__ at top of file

@SparkQA
Copy link

SparkQA commented Aug 19, 2015

Test build #41232 has finished for PR 8102 at commit 879474d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class VectorSlicer(JavaTransformer, HasInputCol, HasOutputCol):

@SparkQA
Copy link

SparkQA commented Aug 19, 2015

Test build #41230 timed out for PR 8102 at commit 5d2f75b after a configured wait of 175m.

@yanboliang yanboliang mentioned this pull request Aug 19, 2015
Closed
@yanboliang
Copy link
Contributor Author

Jenkins, test this please.

@SparkQA
Copy link

SparkQA commented Aug 20, 2015

Test build #41298 has finished for PR 8102 at commit 879474d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class VectorSlicer(JavaTransformer, HasInputCol, HasOutputCol):

@SparkQA
Copy link

SparkQA commented Sep 9, 2015

Test build #42195 has finished for PR 8102 at commit 67bf664.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class VectorSlicer(JavaTransformer, HasInputCol, HasOutputCol):

@jkbradley
Copy link
Member

LGTM. Merging with master. Thank you!

@asfgit asfgit closed this in 56a0fe5 Sep 10, 2015
@yanboliang yanboliang deleted the SPARK-9772 branch September 10, 2015 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@yanboliang @SparkQA @jkbradley